Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix imp[].ext.context.data.adslot issue #627

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Hotfix imp[].ext.context.data.adslot issue #627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/main/java/org/prebid/server/auction/ExchangeService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,10 @@ private BidderRequest createBidderRequest(String bidder, BidRequest bidRequest,
return BidderRequest.of(bidder, bidRequest.toBuilder()
.user(privacyEnforcementResult.getUser())
.device(privacyEnforcementResult.getDevice())
.imp(prepareImps(bidder, imps, firstPartyDataBidders.contains(bidder)))
// FIXME: remove firstPartyDataBidders.isEmpty() after FPD will be reworked
// https://github.com/prebid/prebid-server/issues/879
.imp(prepareImps(bidder, imps,
firstPartyDataBidders.contains(bidder) || firstPartyDataBidders.isEmpty()))
.app(prepareApp(app, extApp, firstPartyDataBidders.contains(bidder)))
.site(prepareSite(site, extSite, firstPartyDataBidders.contains(bidder)))
.source(prepareSource(bidder, bidderToPrebidSchains, bidRequest.getSource()))
Expand Down Expand Up @@ -591,7 +594,9 @@ private List<Imp> prepareImps(String bidder, List<Imp> imps, boolean useFirstPar
private ObjectNode prepareImpExt(String bidder, ObjectNode impExt, boolean useFirstPartyData) {
final ObjectNode result = mapper.mapper().valueToTree(ExtPrebid.of(impExt.get(PREBID_EXT), impExt.get(bidder)));

if (useFirstPartyData) {
// FIXME: consider to remove impExt.get(CONTEXT_EXT) != null after FPD will be reworked
// https://github.com/prebid/prebid-server/issues/879
if (useFirstPartyData && impExt.get(CONTEXT_EXT) != null) {
result.set(CONTEXT_EXT, impExt.get(CONTEXT_EXT));
}

Expand Down