Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supporting gdpr and us_privacy to ConsumableBidder #744

Merged
merged 4 commits into from
Aug 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import com.iab.openrtb.request.Device;
import com.iab.openrtb.request.Format;
import com.iab.openrtb.request.Imp;
import com.iab.openrtb.request.Regs;
import com.iab.openrtb.request.Site;
import com.iab.openrtb.request.User;
import com.iab.openrtb.response.Bid;
Expand All @@ -14,6 +15,7 @@
import org.apache.commons.lang3.StringUtils;
import org.prebid.server.bidder.Bidder;
import org.prebid.server.bidder.consumable.model.ConsumableAdType;
import org.prebid.server.bidder.consumable.model.ConsumableBidGdpr;
import org.prebid.server.bidder.consumable.model.ConsumableBidRequest;
import org.prebid.server.bidder.consumable.model.ConsumableBidResponse;
import org.prebid.server.bidder.consumable.model.ConsumableDecision;
Expand All @@ -28,6 +30,8 @@
import org.prebid.server.json.DecodeException;
import org.prebid.server.json.EncodeException;
import org.prebid.server.json.JacksonMapper;
import org.prebid.server.proto.openrtb.ext.request.ExtRegs;
import org.prebid.server.proto.openrtb.ext.request.ExtUser;
import org.prebid.server.proto.openrtb.ext.request.consumable.ExtImpConsumable;
import org.prebid.server.proto.openrtb.ext.response.BidType;
import org.prebid.server.util.HttpUtil;
Expand Down Expand Up @@ -65,6 +69,28 @@ public Result<List<HttpRequest<ConsumableBidRequest>>> makeHttpRequests(BidReque
.url(site.getPage());
}

final Regs regs = request.getRegs();
final ExtRegs extRegs = regs != null ? regs.getExt() : null;
final String usPrivacy = extRegs != null ? extRegs.getUsPrivacy() : null;
if (usPrivacy != null) {
requestBuilder.usPrivacy(usPrivacy);
}

final Integer gdpr = extRegs != null ? extRegs.getGdpr() : null;
final User user = request.getUser();
final ExtUser extUser = user != null ? user.getExt() : null;
final String gdprConsent = extUser != null ? extUser.getConsent() : null;
if (gdpr != null || gdprConsent != null) {
final ConsumableBidGdpr.ConsumableBidGdprBuilder bidGdprBuilder = ConsumableBidGdpr.builder();
if (gdpr != null) {
bidGdprBuilder.applies(gdpr != 0);
}
if (gdprConsent != null) {
bidGdprBuilder.consent(gdprConsent).build();
}
requestBuilder.gdpr(bidGdprBuilder.build());
}

try {
resolveRequestFields(requestBuilder, request.getImp());
} catch (PreBidException e) {
Expand Down Expand Up @@ -163,7 +189,6 @@ public Result<List<BidderBid>> makeBids(HttpCall<ConsumableBidRequest> httpCall,
} catch (DecodeException e) {
return Result.emptyWithError(BidderError.badServerResponse(e.getMessage()));
}

final List<BidderError> errors = new ArrayList<>();
final List<BidderBid> bidderBids = extractBids(bidRequest, consumableResponse.getDecisions(), errors);
return Result.of(bidderBids, errors);
Expand All @@ -172,7 +197,6 @@ public Result<List<BidderBid>> makeBids(HttpCall<ConsumableBidRequest> httpCall,
private static List<BidderBid> extractBids(BidRequest bidRequest, Map<String, ConsumableDecision> impIdToDecisions,
List<BidderError> errors) {
final List<BidderBid> bidderBids = new ArrayList<>();

for (Map.Entry<String, ConsumableDecision> entry : impIdToDecisions.entrySet()) {
final ConsumableDecision decision = entry.getValue();

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package org.prebid.server.bidder.consumable.model;

import lombok.Builder;
import lombok.Value;

@Builder
@Value
public class ConsumableBidGdpr {

Boolean applies;

String consent;
}
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,8 @@ public class ConsumableBidRequest {
Boolean enableBotFiltering;

Boolean parallel;

String usPrivacy;

ConsumableBidGdpr gdpr;
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import com.iab.openrtb.request.Device;
import com.iab.openrtb.request.Format;
import com.iab.openrtb.request.Imp;
import com.iab.openrtb.request.Regs;
import com.iab.openrtb.request.Site;
import com.iab.openrtb.request.User;
import com.iab.openrtb.response.Bid;
Expand All @@ -14,6 +15,7 @@
import org.junit.Before;
import org.junit.Test;
import org.prebid.server.VertxTest;
import org.prebid.server.bidder.consumable.model.ConsumableBidGdpr;
import org.prebid.server.bidder.consumable.model.ConsumableBidRequest;
import org.prebid.server.bidder.consumable.model.ConsumableBidResponse;
import org.prebid.server.bidder.consumable.model.ConsumableContents;
Expand All @@ -27,6 +29,8 @@
import org.prebid.server.bidder.model.HttpResponse;
import org.prebid.server.bidder.model.Result;
import org.prebid.server.proto.openrtb.ext.ExtPrebid;
import org.prebid.server.proto.openrtb.ext.request.ExtRegs;
import org.prebid.server.proto.openrtb.ext.request.ExtUser;
import org.prebid.server.proto.openrtb.ext.request.consumable.ExtImpConsumable;
import org.prebid.server.proto.openrtb.ext.response.BidType;
import org.prebid.server.util.HttpUtil;
Expand Down Expand Up @@ -224,6 +228,21 @@ public void makeHttpRequestsShouldReturnRequestWithExpectedPlacements() {
.unitId(345).unitName("unit").adTypes(Arrays.asList(3, 429)).build());
}

@Test
public void makeHttpRequestsShouldReturnHttpRequestWithCorrectGdprParameters() {
// given
final BidRequest bidRequest = givenBidRequest(identity());

// when
final Result<List<HttpRequest<ConsumableBidRequest>>> result = consumableBidder.makeHttpRequests(bidRequest);

// then
assertThat(result.getValue()).hasSize(1)
.extracting(httpRequest -> mapper.readValue(httpRequest.getBody(), ConsumableBidRequest.class))
.flatExtracting(ConsumableBidRequest::getGdpr)
.containsOnly(ConsumableBidGdpr.builder().applies(true).consent("consent").build());
}

@Test
public void makeBidsShouldReturnErrorIfResponseBodyCouldNotBeParsed() {
// given
Expand Down Expand Up @@ -327,6 +346,9 @@ private static BidRequest givenBidRequestWithTwoImpsAndTwoFormats() {
.ext(mapper.valueToTree(ExtPrebid.of(null,
ExtImpConsumable.of(123, 234, 345, "unit"))))
.build()))
.user(User.builder()
.ext(ExtUser.builder().consent("consent").build())
.build())
.build();
}

Expand All @@ -335,7 +357,11 @@ private static BidRequest givenBidRequest(
Function<Imp.ImpBuilder, Imp.ImpBuilder> impCustomizer) {

return bidRequestCustomizer.apply(BidRequest.builder()
.imp(singletonList(givenImp(impCustomizer))))
.imp(singletonList(givenImp(impCustomizer)))
.regs(Regs.of(null, ExtRegs.of(1, null)))
.user(User.builder()
.ext(ExtUser.builder().consent("consent").build())
.build()))
.build();
}

Expand Down
3 changes: 1 addition & 2 deletions src/test/java/org/prebid/server/it/ConsumableTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public void openrtb2AuctionShouldRespondWithBidsFromConsumable() throws IOExcept
.withHeader("Referer", equalTo("http://www.example.com"))
.withHeader("X-Forwarded-For", equalTo("193.168.244.1"))
.withHeader("Host", equalTo("localhost:8090"))
.withHeader("Content-Length", equalTo("302"))
.withHeader("Content-Length", equalTo("372"))
.withHeader("Content-Type", equalTo("application/json;charset=UTF-8"))
.withCookie("azk", equalTo("CS-UID"))
// The "time" field in consumable bid request is not being checked as its value is Instance.now()
Expand Down Expand Up @@ -65,7 +65,6 @@ public void openrtb2AuctionShouldRespondWithBidsFromConsumable() throws IOExcept
final String expectedAuctionResponse = openrtbAuctionResponseFrom(
"openrtb2/consumable/test-auction-consumable-response.json",
response, singletonList("consumable")).replaceAll("\\{\\{time}}", timeMs);

JSONAssert.assertEquals(expectedAuctionResponse, response.asString(), JSONCompareMode.NON_EXTENSIBLE);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@
},
"regs": {
"ext": {
"gdpr": 0
"gdpr": 0,
"us_privacy": "1YNN"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,10 @@
"includePricingData": true,
"url": "http://www.example.com",
"enableBotFiltering": true,
"parallel": true
"parallel": true,
"gdpr": {
"applies": false,
"consent": "consentValue"
},
"us_privacy": "1YNN"
}