Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Adhese bidder #770

Merged
merged 10 commits into from
Aug 4, 2020
Merged

Add Adhese bidder #770

merged 10 commits into from
Aug 4, 2020

Conversation

AndriyPavlyuk
Copy link
Contributor

AdheseBidder and tests.
Some fixes that do not exist in Go version.

  1. seatbid[].bid[].impid is taken from the original request.
  2. seatbid[].bid[].id is hardcoded "1" for now. PBS-core will overwrite it if that feature is configured.

@AndriyPavlyuk AndriyPavlyuk requested a review from rpanchyk June 18, 2020 17:31
DGarbar
DGarbar suggested changes Jul 1, 2020
View reviewed changes
src/main/java/org/prebid/server/bidder/adhese/AdheseBidder.java Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/adhese/AdheseBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/adhese/AdheseBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/adhese/AdheseBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/adhese/AdheseBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/adhese/AdheseBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/adhese/AdheseBidder.java Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/adhese/AdheseBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/adhese/AdheseBidder.java Outdated Show resolved Hide resolved
src/test/java/org/prebid/server/bidder/adhese/AdheseBidderTest.java Outdated Show resolved Hide resolved
@rpanchyk rpanchyk changed the title Add implementation of AdheseBidder and tests Add implementation of Adhese bidder Jul 6, 2020
@rpanchyk rpanchyk changed the title Add implementation of Adhese bidder Add Adhese bidder Jul 6, 2020
@rpanchyk rpanchyk merged commit e132fa9 into master Aug 4, 2020
@rpanchyk rpanchyk deleted the add-adhese-bidder branch August 4, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpanchyk rpanchyk rpanchyk approved these changes

@DGarbar DGarbar DGarbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndriyPavlyuk @DGarbar @rpanchyk