-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow zero price for deal bids #774
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/org/prebid/server/bidder/rubicon/RubiconBidder.java # src/test/java/org/prebid/server/bidder/rubicon/RubiconBidderTest.java
rpanchyk
suggested changes
Aug 20, 2020
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
rpanchyk
previously approved these changes
Sep 7, 2020
# Conflicts: # src/main/java/org/prebid/server/auction/BidResponseCreator.java
rpanchyk
approved these changes
Oct 9, 2020
BraslavskiyAndrey
added a commit
that referenced
this pull request
Nov 2, 2020
* Prebid Server prepare release 1.45.0 * Prebid Server prepare for next development iteration * Perform additional validation of stored responses * Set default ad server currency to USD (#818) * Update currency rates endpoint URL and response body (#820) * Use single default-timeout-ms configuration value for both vendor list services (#841) * Provide additional configuration options for http client behavior (#843) * Push stored responses merging up the pipeline so that they are treated more like regular responses (#862) * Do not include bidders without usersync URL in /cookie-sync response (#949) * Allow zero price for deal bids (#774) * Add inMobi bidder (#935) * Add inMobi bidder * Fixes after review * Fixes after review * Fixes after review Co-authored-by: Serhii Nahornyi <snahornyi@rubiconproject.com> * Remove unnecessary status check in makeBids method (#945) Co-authored-by: Sergii Chernysh <schernysh@rubiconproject.com> Co-authored-by: Sergii Chernysh <schernysh@users.noreply.github.com> Co-authored-by: Braslavskyi Andrii <abraslavskyi@rubiconproject.com> Co-authored-by: Serhii Nahornyi <sergiy3344@gmail.com> Co-authored-by: Serhii Nahornyi <snahornyi@rubiconproject.com>
SerhiiNahornyi
pushed a commit
that referenced
this pull request
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.