-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TCF metrics to reflect real bidding #798
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGarbar
previously approved these changes
Jul 9, 2020
DGarbar
previously approved these changes
Sep 1, 2020
DGarbar
previously approved these changes
Sep 1, 2020
# Conflicts: # src/main/java/org/prebid/server/auction/PrivacyEnforcementService.java # src/main/java/org/prebid/server/privacy/gdpr/TcfDefinerService.java # src/test/java/org/prebid/server/auction/PrivacyEnforcementServiceTest.java # src/test/java/org/prebid/server/metric/MetricsTest.java # src/test/java/org/prebid/server/privacy/gdpr/TcfDefinerServiceTest.java
schernysh
reviewed
Nov 24, 2020
src/main/java/org/prebid/server/auction/PrivacyEnforcementService.java
Outdated
Show resolved
Hide resolved
schernysh
approved these changes
Nov 26, 2020
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
privacy.tcf.(v1,v2).requests
- number of requests by TCF version.userid_removed
andgeo_masked
TCF metrics if no sensitive private information to hide.userid_removed
,geo_masked
andanalytics_blocked
TCF metrics ifrequest_blocked
is triggered by privacy enforcement.unknown_geo, in_geo, out_geo
) to be send only for valid consent string.