Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TCF metrics to reflect real bidding #798

Merged
merged 10 commits into from
Dec 11, 2020

Conversation

rpanchyk
Copy link
Contributor

@rpanchyk rpanchyk commented Jul 9, 2020

Changes:

  • Added new metric: privacy.tcf.(v1,v2).requests - number of requests by TCF version.
  • Don't send userid_removed and geo_masked TCF metrics if no sensitive private information to hide.
  • Don't send userid_removed, geo_masked and analytics_blocked TCF metrics if request_blocked is triggered by privacy enforcement.
  • Fix TCF geo metrics (unknown_geo, in_geo, out_geo) to be send only for valid consent string.

@rpanchyk rpanchyk requested a review from DGarbar July 9, 2020 11:39
DGarbar
DGarbar previously approved these changes Jul 9, 2020
DGarbar
DGarbar previously approved these changes Sep 1, 2020
DGarbar
DGarbar previously approved these changes Sep 1, 2020
# Conflicts:
#	src/main/java/org/prebid/server/auction/PrivacyEnforcementService.java
#	src/main/java/org/prebid/server/privacy/gdpr/TcfDefinerService.java
#	src/test/java/org/prebid/server/auction/PrivacyEnforcementServiceTest.java
#	src/test/java/org/prebid/server/metric/MetricsTest.java
#	src/test/java/org/prebid/server/privacy/gdpr/TcfDefinerServiceTest.java
@rpanchyk rpanchyk merged commit de4a833 into master Dec 11, 2020
@rpanchyk rpanchyk deleted the tcf-metrics-reflects-real-bidding branch December 11, 2020 11:07
nickluck9 pushed a commit that referenced this pull request Aug 9, 2021
nickluck9 pushed a commit that referenced this pull request Aug 10, 2021
nickluck9 pushed a commit that referenced this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants