Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Beintoo bidder #813

Merged
merged 9 commits into from
Sep 22, 2020
Merged

Add Beintoo bidder #813

merged 9 commits into from
Sep 22, 2020

Conversation

AndriyPavlyuk
Copy link
Contributor

No description provided.

@AndriyPavlyuk AndriyPavlyuk requested a review from rpanchyk July 15, 2020 14:52
DGarbar
DGarbar suggested changes Sep 16, 2020
View reviewed changes
src/main/java/org/prebid/server/bidder/beintoo/BeintooBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/beintoo/BeintooBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/beintoo/BeintooBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/beintoo/BeintooBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/beintoo/BeintooBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/beintoo/BeintooBidder.java Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/beintoo/BeintooBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/beintoo/BeintooBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/beintoo/BeintooBidder.java Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/beintoo/BeintooBidder.java Outdated Show resolved Hide resolved
@rpanchyk rpanchyk changed the title Add implementation and tests of BeintooBidder Add Beintoo bidder Sep 18, 2020
DGarbar
DGarbar suggested changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@DGarbar DGarbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private static final String DEFAULT_BID_CURRENCY = "USD"; redundant

src/main/java/org/prebid/server/bidder/beintoo/BeintooBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/beintoo/BeintooBidder.java Outdated Show resolved Hide resolved
@rpanchyk rpanchyk merged commit 04bcb6f into master Sep 22, 2020
@rpanchyk rpanchyk deleted the add-beintoo-bidder branch September 22, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpanchyk rpanchyk rpanchyk approved these changes

@DGarbar DGarbar DGarbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndriyPavlyuk @DGarbar @rpanchyk