Refactoring of AuctionContext workflow #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…analects + Refactored ExchangeService with tests. We need to know information about TCF in high level classes. P.S. Mb we can change AuctionContext into mutable object and change bidResponse place.
# Conflicts: # src/main/java/org/prebid/server/auction/BidResponseCreator.java # src/main/java/org/prebid/server/auction/ExchangeService.java # src/main/java/org/prebid/server/handler/openrtb2/AmpHandler.java # src/main/java/org/prebid/server/handler/openrtb2/AuctionHandler.java # src/main/java/org/prebid/server/handler/openrtb2/VideoHandler.java # src/main/java/org/prebid/server/spring/config/ServiceConfiguration.java # src/test/java/org/prebid/server/auction/BidResponseCreatorTest.java # src/test/java/org/prebid/server/auction/ExchangeServiceTest.java # src/test/java/org/prebid/server/handler/openrtb2/AmpHandlerTest.java # src/test/java/org/prebid/server/handler/openrtb2/AuctionHandlerTest.java # src/test/java/org/prebid/server/handler/openrtb2/VideoHandlerTest.java
DGarbar
commented
Oct 9, 2020
src/main/java/org/prebid/server/handler/openrtb2/AmpHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/handler/openrtb2/VideoHandler.java
Outdated
Show resolved
Hide resolved
…ed-tcf-exchange-refactoring # Conflicts: # src/main/java/org/prebid/server/auction/ExchangeService.java # src/test/java/org/prebid/server/auction/ExchangeServiceTest.java
DGarbar
changed the title
DGarbar
added a commit
that referenced
this pull request
Oct 20, 2020
It can be refactored after #815 will be merged
# Conflicts: # src/main/java/org/prebid/server/auction/BidResponseCreator.java # src/main/java/org/prebid/server/auction/ExchangeService.java # src/main/java/org/prebid/server/auction/StoredResponseProcessor.java # src/main/java/org/prebid/server/auction/model/AuctionContext.java # src/main/java/org/prebid/server/handler/openrtb2/AmpHandler.java # src/main/java/org/prebid/server/handler/openrtb2/AuctionHandler.java # src/main/java/org/prebid/server/handler/openrtb2/VideoHandler.java # src/test/java/org/prebid/server/auction/BidResponseCreatorTest.java # src/test/java/org/prebid/server/auction/ExchangeServiceTest.java # src/test/java/org/prebid/server/auction/StoredResponseProcessorTest.java # src/test/java/org/prebid/server/handler/openrtb2/AmpHandlerTest.java # src/test/java/org/prebid/server/handler/openrtb2/AuctionHandlerTest.java # src/test/java/org/prebid/server/handler/openrtb2/VideoHandlerTest.java
Net-burst
requested review from
Net-burst and
And1sS
and removed request for
schernysh
added 3 commits
September 30, 2021 13:59
# Conflicts: # src/main/java/org/prebid/server/auction/ExchangeService.java # src/main/java/org/prebid/server/handler/openrtb2/AmpHandler.java # src/test/java/org/prebid/server/auction/ExchangeServiceTest.java # src/test/java/org/prebid/server/handler/openrtb2/AmpHandlerTest.java
# Conflicts: # src/main/java/org/prebid/server/auction/ExchangeService.java # src/test/java/org/prebid/server/auction/ExchangeServiceTest.java
# Conflicts: # src/main/java/org/prebid/server/auction/VideoResponseFactory.java # src/main/java/org/prebid/server/handler/openrtb2/VideoHandler.java # src/test/java/org/prebid/server/handler/openrtb2/VideoHandlerTest.java
rpanchyk
previously approved these changes
Nov 9, 2021
SerhiiNahornyi
changed the title
# Conflicts: # src/main/java/org/prebid/server/handler/openrtb2/AmpHandler.java # src/main/java/org/prebid/server/handler/openrtb2/AuctionHandler.java # src/main/java/org/prebid/server/handler/openrtb2/VideoHandler.java # src/test/java/org/prebid/server/handler/openrtb2/VideoHandlerTest.java
rpanchyk
approved these changes
Nov 11, 2021
SerhiiNahornyi
deleted the
analytics-blocked-tcf-exchange-refactoring
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea is to make
AuctionContextto have information about each individual request. (AuctionParticipation)This will allow simplify method signature and will make work with (
bidderRequest,bidderResponse) less clumsy.Also notice that blocked requests has more explicit workflow in the code. (Previously we just return null and silently filter them out). Now we can see each
AuctionParticipationeven if it was blocked.Notice that code is making refactoring without any workflow changes (probably only in metrics so I left TODO to resolve with @rpanchyk ).
The next step is to resolve second TODO and make modularity actually see blocked
AuctionParticipationand resolve them in the code.!!! Concerns: Notice that we will work (more) with incomplete
AuctionContext. I mean that we could passAuctionContextthat won't have bidResponse or some value yet because it was not populated. And the same think withAuctionParticipation.(Also keep in mind that if we populating object outside of pipe (ampEventBuilder for example) and we have the Exception before population of this object, we would have incomplete object in the setHandler)
This is the main concerns regarding this change.