Add bid size and secure markup validations, controlled by host through configuration #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 28, 2020 11:36
added 12 commits
September 1, 2020 17:00
… configuration or account
…in addition to verifying there is no insecure markers
DGarbar
suggested changes
Nov 12, 2020
src/main/java/org/prebid/server/metric/ValidationErrorMetrics.java
Outdated
Show resolved
Hide resolved
rpanchyk
previously approved these changes
Dec 14, 2020
DGarbar
previously approved these changes
Dec 14, 2020
# Conflicts: # src/main/java/org/prebid/server/spring/config/ServiceConfiguration.java
rpanchyk
approved these changes
Dec 17, 2020
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
…h configuration (#830) * Add bid size and secure markup validations, controlled by host through configuration * Add account-level bid validations overrides * Apply account level overrides for bid validations * Represent sizes list as string * Update validation error metrics * Include new configuration properties in documentation * Fix broken test * Make use of BidderAliases to correctly resolve aliases on metrics reporting * Change validation logic for banners: validate max size if enforced by configuration or account * Change validation logic for secure creative: look for secure markers in addition to verifying there is no insecure markers * Add warnings support for bids validation * Fix compilation error after merge * Update validation metrics * Fix documentation and remove obsolete class
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
…h configuration (#830) * Add bid size and secure markup validations, controlled by host through configuration * Add account-level bid validations overrides * Apply account level overrides for bid validations * Represent sizes list as string * Update validation error metrics * Include new configuration properties in documentation * Fix broken test * Make use of BidderAliases to correctly resolve aliases on metrics reporting * Change validation logic for banners: validate max size if enforced by configuration or account * Change validation logic for secure creative: look for secure markers in addition to verifying there is no insecure markers * Add warnings support for bids validation * Fix compilation error after merge * Update validation metrics * Fix documentation and remove obsolete class
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
…h configuration (#830) * Add bid size and secure markup validations, controlled by host through configuration * Add account-level bid validations overrides * Apply account level overrides for bid validations * Represent sizes list as string * Update validation error metrics * Include new configuration properties in documentation * Fix broken test * Make use of BidderAliases to correctly resolve aliases on metrics reporting * Change validation logic for banners: validate max size if enforced by configuration or account * Change validation logic for secure creative: look for secure markers in addition to verifying there is no insecure markers * Add warnings support for bids validation * Fix compilation error after merge * Update validation metrics * Fix documentation and remove obsolete class
SerhiiNahornyi
pushed a commit
that referenced
this pull request
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses bids validations as outlined in prebid/prebid-server#1288