Make aliases first-class citizens and look very much the same as core bidders #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schernysh
changed the title
# Conflicts: # docs/developers/add-new-bidder.md # src/main/java/org/prebid/server/auction/AuctionRequestFactory.java # src/main/java/org/prebid/server/auction/BidderAliases.java # src/main/java/org/prebid/server/auction/PrivacyEnforcementService.java # src/main/java/org/prebid/server/bidder/BidderCatalog.java # src/main/java/org/prebid/server/bidder/BidderDeps.java # src/main/java/org/prebid/server/handler/AuctionHandler.java # src/main/java/org/prebid/server/handler/CookieSyncHandler.java # src/main/java/org/prebid/server/spring/config/bidder/AdformConfiguration.java # src/main/java/org/prebid/server/spring/config/bidder/AppnexusConfiguration.java # src/main/java/org/prebid/server/spring/config/bidder/ConversantConfiguration.java # src/main/java/org/prebid/server/spring/config/bidder/FacebookConfiguration.java # src/main/java/org/prebid/server/spring/config/bidder/IxConfiguration.java # src/main/java/org/prebid/server/spring/config/bidder/LifestreetConfiguration.java # src/main/java/org/prebid/server/spring/config/bidder/PubmaticConfiguration.java # src/main/java/org/prebid/server/spring/config/bidder/PulsepointConfiguration.java # src/main/java/org/prebid/server/spring/config/bidder/SovrnConfiguration.java # src/main/java/org/prebid/server/spring/config/bidder/util/BidderDepsAssembler.java # src/test/java/org/prebid/server/auction/AuctionRequestFactoryTest.java # src/test/java/org/prebid/server/auction/PrivacyEnforcementServiceTest.java # src/test/java/org/prebid/server/bidder/BidderCatalogTest.java # src/test/java/org/prebid/server/handler/AuctionHandlerTest.java # src/test/java/org/prebid/server/handler/CookieSyncHandlerTest.java # src/test/java/org/prebid/server/it/ApplicationTest.java # src/test/resources/org/prebid/server/it/auction/districtm/test-auction-districtm-response.json
SerhiiNahornyi
approved these changes
Apr 6, 2021
rpanchyk
approved these changes
Apr 7, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
… bidders (#927) * Make aliases first-class citizens and look very much the same as ordinary bidder * Improve documentation on bidder aliases * Validate that the bidders and aliases are unique
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
… bidders (#927) * Make aliases first-class citizens and look very much the same as ordinary bidder * Improve documentation on bidder aliases * Validate that the bidders and aliases are unique
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
… bidders (#927) * Make aliases first-class citizens and look very much the same as ordinary bidder * Improve documentation on bidder aliases * Validate that the bidders and aliases are unique
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements prebid/prebid-server#1429.
Important: Breaking change
This PR has implications for host companies that rely on aliases support that was already present in PBS.
First, the format for defining aliases has slightly changed. Previously one could declare alias as:
or
With this change in place at least one alias configuration property should be specified so that the framework could pick it up (suggested property is
enabledsince it has to be defined anyway for every alias):or
Second, aliases defined in default configuration (
districtmforappnexusand33acrossforttxfor the time being) are disabled from now on. If you need them enabled in your installation, please turn them on via configuration: