Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First class line indent checkstyle rule #942

Merged
merged 1 commit into from
Oct 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@
<property name="maximum" value="0"/>
<property name="message" value="Line has trailing spaces."/>
</module>
<module name="RegexpMultiline">
<property name="format" value="^([^\n ]+ )*(class|interface|enum) [^{]*\{\n[^\n}]"/>
<property name="message" value="Leave empty row after class/interface/enum definition!"/>
<property name="severity" value="error"/>
<property name="fileExtensions" value="groovy,java"/>
</module>
<module name="RegexpMultiline">
<property name="format" value="System\.(out|err)\.print"/>
</module>
Expand Down
1 change: 1 addition & 0 deletions src/main/java/com/iab/openrtb/request/DataObject.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
@Builder(toBuilder = true)
@Value
public class DataObject {

Integer type;

Integer len;
Expand Down
1 change: 1 addition & 0 deletions src/main/java/com/iab/openrtb/request/EventTracker.java
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
@Builder
@Value
public class EventTracker {

Integer event;

List<Integer> methods;
Expand Down
1 change: 1 addition & 0 deletions src/main/java/com/iab/openrtb/request/ImageObject.java
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
@Builder(toBuilder = true)
@Value
public class ImageObject {

Integer type;

Integer w;
Expand Down
1 change: 1 addition & 0 deletions src/main/java/com/iab/openrtb/request/TitleObject.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
@Builder(toBuilder = true)
@Value
public class TitleObject {

Integer len;

ObjectNode ext;
Expand Down
1 change: 1 addition & 0 deletions src/main/java/com/iab/openrtb/request/VideoObject.java
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
@Builder(toBuilder = true)
@Value
public class VideoObject {

List<String> mimes;

Integer minduration;
Expand Down
1 change: 1 addition & 0 deletions src/main/java/com/iab/openrtb/request/ntv/Protocol.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* Options for the various bid response protocols that could be supported by an exchange.
*/
public enum Protocol {

/**
* VAST 1.0
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import java.util.stream.Collectors;

public class AdvangelistsBidder implements Bidder<BidRequest> {

private static final TypeReference<ExtPrebid<?, ExtImpAdvangelists>> ADVANGELISTS_EXT_TYPE_REFERENCE = new
TypeReference<ExtPrebid<?, ExtImpAdvangelists>>() {
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
@Value
@AllArgsConstructor(staticName = "of")
public class PublisherOverride {

/**
* Blocked advertisers.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@
@AllArgsConstructor(staticName = "of")
@Value
public class ExtImpGrid {

Integer uid;
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* ImproveDigital {@link Bidder} implementation.
*/
public class ImprovedigitalBidder extends OpenrtbBidder<Void> {

public ImprovedigitalBidder(String endpointUrl, JacksonMapper mapper) {
super(endpointUrl, RequestCreationStrategy.SINGLE_REQUEST, Void.class, mapper);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import java.util.stream.Collectors;

public class LunamediaBidder implements Bidder<BidRequest> {

private static final TypeReference<ExtPrebid<?, ExtImpLunamedia>> IMP_EXT_TYPE_REFERENCE = new
TypeReference<ExtPrebid<?, ExtImpLunamedia>>() {
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import java.util.stream.Collectors;

public class NinthdecimalBidder implements Bidder<BidRequest> {

private static final TypeReference<ExtPrebid<?, ExtImpNinthdecimal>> NINTHDECIMAL_EXT_TYPE_REFERENCE = new
TypeReference<ExtPrebid<?, ExtImpNinthdecimal>>() {
};
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.prebid.server.bidder.openx.model;

public enum OpenxImpType {

// supported
banner, video,
//not supported
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
@Value
@AllArgsConstructor(staticName = "of")
public class PubmaticBidExt {

@JsonProperty("BidType")
Integer bidType;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import org.prebid.server.json.JacksonMapper;

public class RtbhouseBidder extends OpenrtbBidder<Void> {

public RtbhouseBidder(String endpointUrl, JacksonMapper mapper) {
super(endpointUrl, RequestCreationStrategy.SINGLE_REQUEST, Void.class, mapper);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
import java.util.zip.GZIPInputStream;

public class TelariaBidder implements Bidder<BidRequest> {

private static final String DEFAULT_BID_CURRENCY = "USD";
private static final TypeReference<ExtPrebid<?, ExtImpTelaria>> TELARIA_EXT_TYPE_REFERENCE =
new TypeReference<ExtPrebid<?, ExtImpTelaria>>() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
* Ucfunnel {@link Bidder} implementation.
*/
public class UcfunnelBidder implements Bidder<BidRequest> {

private static final TypeReference<ExtPrebid<?, ExtImpUcfunnel>> UCFUNNEL_EXT_TYPE_REFERENCE =
new TypeReference<ExtPrebid<?, ExtImpUcfunnel>>() {
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import java.util.List;

public class VrtcalBidder extends OpenrtbBidder<ExtImpVrtcal> {

public VrtcalBidder(String endpointUrl, JacksonMapper mapper) {
super(endpointUrl, RequestCreationStrategy.SINGLE_REQUEST, ExtImpVrtcal.class, mapper);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
* Yieldone {@link Bidder} implementation.
*/
public class YieldoneBidder implements Bidder<BidRequest> {

private static final TypeReference<ExtPrebid<?, ExtImpYieldone>> YIELDONE_EXT_TYPE_REFERENCE =
new TypeReference<ExtPrebid<?, ExtImpYieldone>>() {
};
Expand Down
1 change: 1 addition & 0 deletions src/main/java/org/prebid/server/health/model/Status.java
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.prebid.server.health.model;

public enum Status {

UP,
DOWN
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@
* Describes all available {@link IdGenerator} types.
*/
public enum IdGeneratorType {

none, uuid
}
1 change: 1 addition & 0 deletions src/main/java/org/prebid/server/metric/CounterType.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package org.prebid.server.metric;

public enum CounterType {

counter, flushingCounter, meter
}
1 change: 1 addition & 0 deletions src/main/java/org/prebid/server/metric/MetricName.java
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.prebid.server.metric;

public enum MetricName {

// connection
connection_accept_errors,

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.prebid.server.metric.model;

public enum AccountMetricsVerbosityLevel {

none, basic, detailed;

public boolean isAtLeast(AccountMetricsVerbosityLevel another) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
@AllArgsConstructor(staticName = "of")
@Value
public class ExtImpConsumable {

@JsonProperty("networkId")
Integer networkId;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
@AllArgsConstructor(staticName = "of")
@Value
public class ExtImpEmxDigital {

String tagid;

String bidfloor;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
)
@Value
public class ExtImpMgid {

@JsonProperty("accountId")
String accountId;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
@Builder
@Value
public class ExtImpOpenx {

String unit;

@JsonProperty("delDomain")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
)
@Value
public class ExtImpVisx {

Integer uid;

List<Integer> size;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
@AllArgsConstructor(staticName = "of")
@Value
public class ExtImpZeroclickfraud {

@JsonProperty("sourceId")
Integer sourceId;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import com.fasterxml.jackson.annotation.JsonProperty;

public enum BidType {

banner,
video,
audio,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package org.prebid.server.proto.response;

public enum MediaType {

banner, video
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import com.fasterxml.jackson.annotation.JsonCreator;

public enum EnforcePurpose {

no, basic, full;

@JsonCreator
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@
* Defines the type of stored data, used in creating {@link StoredDataResult}.
*/
public enum StoredDataType {

request, imp, seatbid
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,6 @@
*/
@FunctionalInterface
public interface TriFunction<T, U, V, R> {

R apply(T t, U u, V v);
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
@Configuration
@PropertySource(value = "classpath:/bidder-config/kidoz.yaml", factory = YamlPropertySourceFactory.class)
public class KidozConfiguration {

private static final String BIDDER_NAME = "kidoz";

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
@Configuration
@PropertySource(value = "classpath:/bidder-config/valueimpression.yaml", factory = YamlPropertySourceFactory.class)
public class ValueImpressionConfiguration {

private static final String BIDDER_NAME = "valueimpression";

@Autowired
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import static org.prebid.server.proto.openrtb.ext.response.BidType.banner;

public class AjaBidderTest extends VertxTest {

private static final String ENDPOINT_URL = "https://test.endpoint.com";

private AjaBidder ajaBidder;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;

public class UcfunnelBidderTest extends VertxTest {

private static final String ENDPOINT_URL = "https://test.endpoint.com";

private UcfunnelBidder ucfunnelBidder;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
import static org.assertj.core.api.Assertions.within;

public class YieldlabBidderTest extends VertxTest {

private static final String ENDPOINT_URL = "https://test.endpoint.com";

private YieldlabBidder yieldlabBidder;
Expand Down
1 change: 1 addition & 0 deletions src/test/java/org/prebid/server/it/AdgenerationTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@

@RunWith(SpringRunner.class)
public class AdgenerationTest extends IntegrationTest {

@Test
public void openrtb2AuctionShouldRespondWithBidsFromAdgeneration() throws IOException, JSONException {
// given
Expand Down
1 change: 1 addition & 0 deletions src/test/java/org/prebid/server/it/UcfunnelTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

@RunWith(SpringRunner.class)
public class UcfunnelTest extends IntegrationTest {

@Test
public void openrtb2AuctionShouldRespondWithBidsFromUcfunnel() throws IOException, JSONException {
// given
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import static org.assertj.core.api.Assertions.assertThat;

public class CookieSyncMetricsTest {

@Test
public void forBidderShouldReturnSameBidderCookieSyncMetricsOnSuccessiveCalls() {
// given
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import static org.mockito.BDDMockito.given;

public class BasicEnforcePurposeStrategyTest {

private static final int PURPOSE_ID = 1;

@Rule
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import static org.mockito.Mockito.verifyZeroInteractions;

public class FullEnforcePurposeStrategyTest {

private static final int PURPOSE_ID = 1;

@Rule
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import static org.mockito.BDDMockito.given;

public class NoEnforcePurposeStrategyTest {

private static final int PURPOSE_ID = 1;

@Rule
Expand Down