Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invibes bidder/development #957

Merged
merged 6 commits into from
Nov 13, 2020
Merged

Invibes bidder/development #957

merged 6 commits into from
Nov 13, 2020

Conversation

SerhiiNahornyi
Copy link
Collaborator

No description provided.

@SerhiiNahornyi SerhiiNahornyi force-pushed the invibes_bidder/development branch 2 times, most recently from e6ef2d1 to c09c041 Compare October 20, 2020 22:31
@SerhiiNahornyi SerhiiNahornyi force-pushed the invibes_bidder/development branch from c09c041 to b68385d Compare October 20, 2020 22:47
DGarbar
DGarbar suggested changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@DGarbar DGarbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boolean.TRUE -> true
Boolean.FALSE -> false
in Tests

src/main/resources/bidder-config/invibes.yaml Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/invibes/InvibesBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/invibes/InvibesBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/invibes/InvibesBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/invibes/InvibesBidder.java Outdated Show resolved Hide resolved
src/test/java/org/prebid/server/bidder/invibes/InvibesBidderTest.java Outdated Show resolved Hide resolved
src/test/java/org/prebid/server/bidder/invibes/InvibesBidderTest.java Outdated Show resolved Hide resolved
src/test/java/org/prebid/server/bidder/invibes/InvibesBidderTest.java Show resolved Hide resolved
src/test/java/org/prebid/server/bidder/invibes/InvibesBidderTest.java Show resolved Hide resolved
src/test/java/org/prebid/server/bidder/invibes/InvibesBidderTest.java Show resolved Hide resolved
DGarbar
DGarbar suggested changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@DGarbar DGarbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that you left site check. But what the point of checking and prepearing all values if we can fail at the end ?
Java = Fail Fast

src/main/java/org/prebid/server/bidder/invibes/InvibesBidder.java Outdated Show resolved Hide resolved
src/test/java/org/prebid/server/bidder/invibes/InvibesBidderTest.java Outdated Show resolved Hide resolved
@rpanchyk rpanchyk merged commit 9aa3f42 into master Nov 13, 2020
@rpanchyk rpanchyk deleted the invibes_bidder/development branch November 13, 2020 13:49
SerhiiNahornyi pushed a commit that referenced this pull request May 13, 2022
Add alias resolving for pbjs channel to RubiconAnalyticsReporter. (#…
8083496 
…957)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DGarbar DGarbar DGarbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SerhiiNahornyi @DGarbar @rpanchyk