Skip to content

Commit

Permalink
adjust exchange tests
Browse files Browse the repository at this point in the history
  • Loading branch information
andre-gielow-ttd committed Jul 31, 2024
1 parent b2d924f commit 1474c4d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
8 changes: 5 additions & 3 deletions adapters/thetradedesk/thetradedesk.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,11 @@ func Builder(bidderName openrtb_ext.BidderName, config config.Adapter, server co
return nil, fmt.Errorf("unable to parse endpoint url template: %v", err)
}

isValidEndpoint, err := regexp.Match("([a-z]*)$", []byte(config.ExtraAdapterInfo))
if !isValidEndpoint || err != nil {
return nil, errors.New("ExtraAdapterInfo must be a simple string provided by TheTradeDesk")
if len(config.ExtraAdapterInfo) > 0 {
isValidEndpoint, err := regexp.Match("([a-z]+)$", []byte(config.ExtraAdapterInfo))
if !isValidEndpoint || err != nil {
return nil, errors.New("ExtraAdapterInfo must be a simple string provided by TheTradeDesk")
}
}

urlParams := macros.EndpointTemplateParams{SupplyId: config.ExtraAdapterInfo}
Expand Down
2 changes: 1 addition & 1 deletion adapters/thetradedesk/thetradedesk_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func TestEndpointTemplateMalformed(t *testing.T) {
func TestBadConfig(t *testing.T) {
_, buildErr := Builder(openrtb_ext.BidderTheTradeDesk, config.Adapter{
Endpoint: `http://it.doesnt.matter/bid`,
ExtraAdapterInfo: `{foo:42}`,
ExtraAdapterInfo: "12365217635",
},
config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})

Expand Down

0 comments on commit 1474c4d

Please sign in to comment.