Skip to content

Commit

Permalink
Rubicon: No longer copy certain FPD fields (#3919)
Browse files Browse the repository at this point in the history 
Co-authored-by: ddubyk <ddubyk@magnite.com>
  • Loading branch information
@CTMBNara
CTMBNara and ddubyk authored Dec 13, 2024
1 parent b2023fd commit 35e389f
Show file tree
Hide file tree
Showing 14 changed files with 0 additions and 100 deletions.
18 changes: 0 additions & 18 deletions adapters/rubicon/rubicon.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -646,21 +646,9 @@ func (a *RubiconAdapter) updateImpRpTarget(extImp rubiconExtImpBidder, extImpRub
if err != nil {
return nil, err
}
if len(site.SectionCat) > 0 {
addStringArrayAttribute(site.SectionCat, target, "sectioncat")
}
if len(site.PageCat) > 0 {
addStringArrayAttribute(site.PageCat, target, "pagecat")
}
if site.Page != "" {
addStringAttribute(site.Page, target, "page")
}
if site.Ref != "" {
addStringAttribute(site.Ref, target, "ref")
}
if site.Search != "" {
addStringAttribute(site.Search, target, "search")
}
} else {
appExtData, _, _, err := jsonparser.Get(app.Ext, "data")
if isNotKeyPathError(err) {
Expand All @@ -670,12 +658,6 @@ func (a *RubiconAdapter) updateImpRpTarget(extImp rubiconExtImpBidder, extImpRub
if err != nil {
return nil, err
}
if len(app.SectionCat) > 0 {
addStringArrayAttribute(app.SectionCat, target, "sectioncat")
}
if len(app.PageCat) > 0 {
addStringArrayAttribute(app.PageCat, target, "pagecat")
}
}

if len(extImp.Context.Data) > 0 {
Expand Down
4 changes: 0 additions & 4 deletions adapters/rubicon/rubicontest/exemplary/25-26-transition-period.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -361,10 +361,6 @@
"rp": {
"target": {
"pbadslot": "pbadslot",
"pagecat": [
"val1",
"val2"
],
"pbs_login": "xuser",
"pbs_url": "http://hosturl.com",
"pbs_version": ""
Expand Down
8 changes: 0 additions & 8 deletions adapters/rubicon/rubicontest/exemplary/app-imp-fpd.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -341,14 +341,6 @@
"attr5": [
"3"
],
"pagecat": [
"val1",
"val2"
],
"sectioncat": [
"sectionCat1",
"sectionCat2"
],
"pbs_login": "xuser",
"pbs_url": "http://hosturl.com",
"pbs_version": ""
Expand Down
12 changes: 0 additions & 12 deletions adapters/rubicon/rubicontest/exemplary/bidonmultiformat.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -101,12 +101,6 @@
"page": [
"somePage"
],
"ref": [
"someRef"
],
"search": [
"someSearch"
],
"pbs_login": "xuser",
"pbs_url": "http://hosturl.com",
"pbs_version": ""
Expand Down Expand Up @@ -210,12 +204,6 @@
"page": [
"somePage"
],
"ref": [
"someRef"
],
"search": [
"someSearch"
],
"pbs_login": "xuser",
"pbs_url": "http://hosturl.com",
"pbs_version": ""
Expand Down
8 changes: 0 additions & 8 deletions adapters/rubicon/rubicontest/exemplary/flexible-schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -341,14 +341,6 @@
"attr5": [
"3"
],
"pagecat": [
"val1",
"val2"
],
"sectioncat": [
"sectionCat1",
"sectionCat2"
],
"pbs_login": "xuser",
"pbs_url": "http://hosturl.com",
"pbs_version": ""
Expand Down
4 changes: 0 additions & 4 deletions adapters/rubicon/rubicontest/exemplary/hardcode-secure.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -319,10 +319,6 @@
"rp": {
"target": {
"pbadslot": "pbadslot",
"pagecat": [
"val1",
"val2"
],
"pbs_login": "xuser",
"pbs_url": "http://hosturl.com",
"pbs_version": ""
Expand Down
6 changes: 0 additions & 6 deletions adapters/rubicon/rubicontest/exemplary/non-bidonmultiformat.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,6 @@
"page": [
"somePage"
],
"ref": [
"someRef"
],
"search": [
"someSearch"
],
"pbs_login": "xuser",
"pbs_url": "http://hosturl.com",
"pbs_version": ""
Expand Down
4 changes: 0 additions & 4 deletions adapters/rubicon/rubicontest/exemplary/simple-banner.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -320,10 +320,6 @@
"rp": {
"target": {
"pbadslot": "pbadslot",
"pagecat": [
"val1",
"val2"
],
"pbs_login": "xuser",
"pbs_url": "http://hosturl.com",
"pbs_version": ""
Expand Down
4 changes: 0 additions & 4 deletions adapters/rubicon/rubicontest/exemplary/simple-native.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -304,10 +304,6 @@
"rp": {
"target": {
"pbadslot": "pbadslot",
"pagecat": [
"val1",
"val2"
],
"pbs_login": "xuser",
"pbs_url": "http://hosturl.com",
"pbs_version": ""
Expand Down
4 changes: 0 additions & 4 deletions adapters/rubicon/rubicontest/exemplary/simple-video.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -320,10 +320,6 @@
"rp": {
"target": {
"pbadslot": "pbadslot",
"pagecat": [
"val1",
"val2"
],
"pbs_login": "xuser",
"pbs_url": "http://hosturl.com",
"pbs_version": ""
Expand Down
14 changes: 0 additions & 14 deletions adapters/rubicon/rubicontest/exemplary/site-imp-fpd.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -458,20 +458,6 @@
"page": [
"somePage"
],
"ref": [
"someRef"
],
"search": [
"someSearch"
],
"pagecat": [
"val1",
"val2"
],
"sectioncat": [
"sectionCat1",
"sectionCat2"
],
"dfp_ad_unit_code": "adSlotFromData",
"pbs_login": "xuser",
"pbs_url": "http://hosturl.com",
Expand Down
6 changes: 0 additions & 6 deletions adapters/rubicon/rubicontest/exemplary/user-fpd.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -268,12 +268,6 @@
"page": [
"somePage"
],
"ref": [
"someRef"
],
"search": [
"someSearch"
],
"dfp_ad_unit_code": "someAdSlot",
"pbs_login": "xuser",
"pbs_url": "http://hosturl.com",
Expand Down
4 changes: 0 additions & 4 deletions adapters/rubicon/rubicontest/supplemental/no-site-content-data.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -230,10 +230,6 @@
"ext": {
"rp": {
"target": {
"pagecat": [
"val1",
"val2"
],
"pbs_login": "xuser",
"pbs_url": "http://hosturl.com",
"pbs_version": ""
Expand Down
4 changes: 0 additions & 4 deletions adapters/rubicon/rubicontest/supplemental/no-site-content.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,6 @@
"ext": {
"rp": {
"target": {
"pagecat": [
"val1",
"val2"
],
"pbs_login": "xuser",
"pbs_url": "http://hosturl.com",
"pbs_version": ""
Expand Down

0 comments on commit 35e389f

Please sign in to comment.