Skip to content

Commit

Permalink
Beachfront: GDPR id (issue 1301) and documentation updates (#1321)
Browse files Browse the repository at this point in the history
* Defined cookie sync URL in config, cleared deprecated comment in usersync

* Update beachfront.md

* editing documentation

* updated gdpr id - issue 1301
  • Loading branch information
muncha authored Jun 2, 2020
1 parent 9f3a8c7 commit 748e2d0
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 4 deletions.
8 changes: 7 additions & 1 deletion adapters/beachfront/usersync.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ import (
"github.com/prebid/prebid-server/usersync"
)

var VENDOR_ID uint16 = 335

func NewBeachfrontSyncer(temp *template.Template) usersync.Usersyncer {
return adapters.NewSyncer("beachfront", 0, temp, adapters.SyncTypeIframe)
return adapters.NewSyncer(
"beachfront",
VENDOR_ID,
temp,
adapters.SyncTypeIframe)
}
2 changes: 1 addition & 1 deletion adapters/beachfront/usersync_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ func TestBeachfrontSyncer(t *testing.T) {
assert.NoError(t, err)
assert.Equal(t, "https://sync.bfmio.com/sync_s2s?gdpr=A&us_privacy=C&url=https%3A%2F%2Flocalhost%3A8888%2Fsetuid%3Fbidder%3Dbeachfront%26gdpr%3DA%26gdpr_consent%3DB%26uid%3D%5Bio_cid%5D", syncInfo.URL)
assert.Equal(t, "iframe", syncInfo.Type)
assert.EqualValues(t, 0, syncer.GDPRVendorID())
assert.EqualValues(t, uint16(335), syncer.GDPRVendorID())
assert.Equal(t, false, syncInfo.SupportCORS)
}
10 changes: 8 additions & 2 deletions docs/bidders/beachfront.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
# Beachfront bidder

To use the beachfront bidder you will need an appId from an exchange
account on [https://platform.beachfront.io](platform.beachfront.io).
To use the beachfront bidder you will need an appId (Exchange Id) from an exchange
account on [platform.beachfront.io](https://platform.beachfront.io).

For further information, please contact adops@beachfront.com.

As seen in the JSON response from \{your PBS server\}\/bidder\/params [(example)](https://prebid.adnxs.com/pbs/v1/bidders/params), the beachfront bidder can take either an "appId" parameter, or an "appIds" parameter. If the request is for one media type, the appId parameter should be used with the value of the Exchange Id on the Beachfront platform.

The appIds parameter is for requesting a mix of banner and video. It has two parameters, "banner", and "video" for the appIds of two appropriately configured exchanges on the platform. The appIds parameter can be sent with just one of its two parameters and it will behave like the appId parameter.

If the request includes an appId configured for a video response, the videoResponseType parameter can be defined as "nurl", "adm" or "both". These will apply to all video returned. If it is not defined, the response type will be a nurl. The definitions for "nurl" vs. "adm" are here: (https://github.com/mxmCherry/openrtb/blob/master/openrtb2/bid.go).

0 comments on commit 748e2d0

Please sign in to comment.