Minor refactoring

prebid · Jun 2, 2021 · 977c999 · 977c999
1 parent 370b63c
commit 977c999
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/adapters/audienceNetwork/audienceNetworktest/exemplary/video_consented_providers.json b/adapters/audienceNetwork/audienceNetworktest/exemplary/video_consented_providers.json
@@ -35,8 +35,7 @@
                 "consent": "TESTCONSENT",
                 "consented_providers_settings": {
                     "consented_providers": [1608,765,492,1365,5678,1545,2563,1411]
-                },
-                "test": 123
+                }
             }
         },
         "tmax": 500
@@ -87,8 +86,7 @@
                         "id": "db089de9-a62e-4861-a881-0ff15e052516",
                         "buyeruid": "v4_bidder_token",
                         "ext": {
-                            "consent": "TESTCONSENT",
-                            "test": 123
+                            "consent": "TESTCONSENT"
                         }
                     },
                     "tmax": 500,

diff --git a/util/jsonutil/jsonutil_test.go b/util/jsonutil/jsonutil_test.go
@@ -110,12 +110,12 @@ func TestDropElement(t *testing.T) {
 	for _, tt := range tests {
 		res, err := DropElement(tt.input, tt.elementToRemove)
 
-		if !tt.errorExpected {
-			assert.NoError(t, err, "Error should be nil")
-			assert.Equal(t, tt.output, res, "Result is incorrect")
-		} else {
+		if tt.errorExpected {
 			assert.Error(t, err, "Error should not be nil")
 			assert.True(t, strings.Contains(err.Error(), tt.errorContains))
+		} else {
+			assert.NoError(t, err, "Error should be nil")
+			assert.Equal(t, tt.output, res, "Result is incorrect")
 		}
 
 	}