IX: update required site id field to be more flexible (#1934)

Co-authored-by: Joshua Gross <joshua.gross@indexexchange.com>

adapters/ix/params_test.go

@@ -0,0 +1,59 @@
+package ix
+
+import (
+	"encoding/json"
+	"testing"
+
+	"github.com/prebid/prebid-server/openrtb_ext"
+)
+
+func TestValidParams(t *testing.T) {
+	validator, err := openrtb_ext.NewBidderParamsValidator("../../static/bidder-params")
+	if err != nil {
+		t.Fatalf("Failed to fetch the json-schemas. %v", err)
+	}
+
+	for _, validParam := range validParams {
+		if err := validator.Validate(openrtb_ext.BidderIx, json.RawMessage(validParam)); err != nil {
+			t.Errorf("Schema rejected ix params: %s", validParam)
+		}
+	}
+}
+
+func TestInvalidParams(t *testing.T) {
+	validator, err := openrtb_ext.NewBidderParamsValidator("../../static/bidder-params")
+	if err != nil {
+		t.Fatalf("Failed to fetch the json-schemas. %v", err)
+	}
+
+	for _, invalidParam := range invalidParams {
+		if err := validator.Validate(openrtb_ext.BidderIx, json.RawMessage(invalidParam)); err == nil {
+			t.Errorf("Schema allowed unexpected params: %s", invalidParam)
+		}
+	}
+}
+
+var validParams = []string{
+	`{"siteid":"1234"}`,
+	`{"siteID":"12345"}`,
+	`{"siteId":"123456"}`,
+	`{"siteid":"1234567", "size": [640,480]}`,
+}
+
+var invalidParams = []string{
+	`{"siteid":""}`,
+	`{"siteID":""}`,
+	`{"siteId":""}`,
+	`{"siteid":"1234", "siteID":"12345"}`,
+	`{"siteid":"1234", "siteId":"123456"}`,
+	`{"siteid":123}`,
+	`{"siteids":"123"}`,
+	`{"notaparam":"123"}`,
+	`{"siteid":"123", "size": [1,2,3]}`,
+	`null`,
+	`true`,
+	`0`,
+	`abc`,
+	`[]`,
+	`{}`,
+}

static/bidder-params/ix.json

@@ -4,10 +4,20 @@
   "description": "A schema which validates params accepted by the Ix adapter",
   "type": "object",
   "properties": {
+    "siteid": {
+      "type": "string",
+      "minLength": 1,
+      "description": "An ID which identifies the site selling the impression, preferred."
+    },
     "siteId": {
       "type": "string",
       "minLength": 1,
-      "description": "An ID which identifies the site selling the impression"
+      "description": "An ID which identifies the site selling the impression."
+    },
+    "siteID": {
+      "type": "string",
+      "minLength": 1,
+      "description": "An ID which identifies the site selling the impression."
     },
     "size": {
       "type": "array",
@@ -19,5 +29,9 @@
       "description": "An array of two integer containing the dimension"
     }
   },
-  "required": ["siteId"]
+  "oneOf": [
+    {"required": ["siteid"]},
+    {"required": ["siteId"]},
+    {"required": ["siteID"]}
+  ]
 }