-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebid Server generated bidId #1171
Comments
I don't have an objection, just some follow-up questions:
Would this apply to all bid requests or be restricted to the video/amp/sdk requests?
To be clear, this is stating the existing bidid will still flow through the system as it does today and PBS will only place its generated uuid in extension object? |
Discussed in the Prebid Server meeting. Bryan brought up the interesting idea of using cache ID instead creating a new ID. We discussed this afterwards and while the idea has solid merit, it ties two concepts together that are not necessarily tied: bids aren’t always cached, and it could be confusing to have a fake cacheId in a scenario where we only needed the ID to be a bid.
Seems easier to just apply it to all bid requests, right? Prebid.js doesn't have to use it.
Right. |
Overwriting bid.id could be controlled by an adapter flag instead of an application-wide one, since this is a bidder issue. |
The implementation in PBS-Java is to (optionally) add a totally separate bidid (seatbid.bid.ext.prebid.bidid) that is then used as the bidid for events purposes. Traceability to bidder-specified bidids is still available in seatbid.bid.id. Notes:
|
Are updates on this? |
@ShriprasadM I've increased it's priority within the Xandr dev team. @VeronikaSolovei9 will be working on it soon. |
Thanks @SyntaxNode for an update |
PR: #1772 |
Implemented in PBS-Go 0.155.0. |
Followup to #1015
An assumption of the video/amp/sdk event tracking feature was that bidders generated reasonably unique IDs for each seatbid[].bid[].id. We've discovered that assumption to be false: bidders are all over the map with regards to that ID:
To be useful for joining truncated events back to the auction ID, we need to make sure that bidIds are unique, and it's become clear that bidder adapters aren't aligned with that goal.
The proposal to address this:
The text was updated successfully, but these errors were encountered: