Overwrite Bid Id #616
Merged
Overwrite Bid Id #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… = true. Test added
# Conflicts: # src/main/java/org/prebid/server/auction/BidResponseCreator.java # src/main/java/org/prebid/server/spring/config/ServiceConfiguration.java # src/test/java/org/prebid/server/auction/BidResponseCreatorTest.java
rpanchyk
suggested changes
Mar 13, 2020
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/ServiceConfiguration.java
Outdated
Show resolved
Hide resolved
DGarbar
suggested changes
Mar 24, 2020
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/proto/openrtb/ext/response/ExtBidPrebid.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/auction/BidResponseCreatorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/auction/BidResponseCreatorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/auction/BidResponseCreatorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/auction/BidResponseCreatorTest.java
Outdated
Show resolved
Hide resolved
DGarbar
suggested changes
Mar 27, 2020
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/auction/BidResponseCreatorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/auction/BidResponseCreatorTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
DGarbar
suggested changes
Mar 31, 2020
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/BidResponseCreator.java
Outdated
Show resolved
Hide resolved
DGarbar
previously approved these changes
Mar 31, 2020
added 2 commits
May 8, 2020 11:51
# Conflicts: # src/main/java/org/prebid/server/auction/BidResponseCreator.java # src/test/java/org/prebid/server/auction/BidResponseCreatorTest.java # src/test/java/org/prebid/server/handler/openrtb2/AmpHandlerTest.java
rpanchyk
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bid Id can be overwritten if application.yaml auction.generate-bid-id = true.
Implements prebid/prebid-server#1171