Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreferDeals Flag #1355

Closed
bretg opened this issue Jun 12, 2020 · 5 comments
Closed

PreferDeals Flag #1355

bretg opened this issue Jun 12, 2020 · 5 comments
Labels
feature request Intent to implement An issue describing a plan for a major feature. These are intended for community feedback pinned

Comments

@bretg
Copy link
Contributor

bretg commented Jun 12, 2020

Exploring the idea of providing more control over how PBS picks the overall winner when it returns ad server targeting. While it's true that PBS always sends the top bid from each bidder in the OpenRTB, some clients can't or don't look at those values, particularly AMP.

Currently, the hb_pb/hb_bidder/hb_adid/etc winning targeting values are determined by the highest bid value. Not the highest value after granularity quantizing, but the highest actual bid. If the targeting isn't in includebidderkeys mode, it means that a deal won't get returned unless it has the highest CPM. Which means basically that pubs who've implemented Send-Top-Bids can miss deal bids.

Proposal:

  • PBS supports a new request flag: ext.prebid.targeting.preferdeals: true to have Prebid Server choose the highest value deal before choosing the highest value non-deal.
  • No need for an account setting, since the flag is mostly relevant for AMP and SDK -- storedrequests can be created that have preferdeals:true.
@bretg
Copy link
Contributor Author

bretg commented Sep 4, 2020

Approved by PBS committee

@hhhjort
Copy link
Collaborator

hhhjort commented Oct 2, 2020

Should this be on the imp.ext level? I just realized this is different from all the other targeting parameters that are on the request level.

@bretg
Copy link
Contributor Author

bretg commented Oct 2, 2020

Good Q. Spoke with a publisher on this -- we think that keeping the flag at the request level is fine.

@SyntaxNode SyntaxNode added Intent to implement An issue describing a plan for a major feature. These are intended for community feedback PBS-Java labels Nov 5, 2020
@bretg
Copy link
Contributor Author

bretg commented May 25, 2021

Updated the issue to reflect the global, rather than per-imp, nature of this flag.

@bretg
Copy link
Contributor Author

bretg commented Jun 11, 2021

Released with PBS-Java 1.66. Docs updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Intent to implement An issue describing a plan for a major feature. These are intended for community feedback pinned
Projects
None yet
Development

No branches or pull requests

3 participants