Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Understanding SupportDeals(PBS), PreferDeals (PBS), SupportDeals (PBS), dealPrioritization (PBJS), prioritizeDeals(PBJS) #2490

Closed
ShriprasadM opened this issue Dec 9, 2022 · 8 comments

Comments

@ShriprasadM
Copy link
Contributor

ShriprasadM commented Dec 9, 2022

@bretg / @SyntaxNode / PrebidTeam , can you confirm if following understanding is correct?

Use Case Should pass following params and configs in PBS go Should pass following params and configs PB JS Should use following keys in Ad Server Targeting
Deal Prioritisation for Long Form Video (LFV) image #1174 image https://docs.prebid.org/dev-docs/modules/adpod.html#cpm-adjustments-by-deal-tier-for-csai hb_pb_cat_dur https://docs.prebid.org/prebid-video/video-long-form.html#deal-support
Prefer Deals - In Prebid Auction only ext.prebid.targeting.preferdeals: true #1355 #1528 dealPrioritization: true https://docs.prebid.org/dev-docs/publisher-api-reference/setConfig.html hb_deal https://docs.prebid.org/adops/deals.html#deal-key-value-pairs
For LFV - To Prefer and prioritise deals support deals = true, preferdeals = true priortizedeals:true, dealPrioritization:true hb_pb_cat_dur
Prefer Non-LFV Prefer and prioritise deals preferdeals = true dealPrioritization:true . hb_deal
@bretg
Copy link
Contributor

bretg commented Dec 9, 2022

I can confirm the behavior of

  • PBS ext.prebid.targeting.preferdeals: if true, this causes PBS to let deals win over non-deals when choosing the winning bid, which is the one that populates hb_pb, hb_size, etc
  • PBJS dealPrioritization: basically the same as PBS ext.prebid.targeting.preferdeals

Unfortunately I cannot comment on the history of long-form video deal support. Will ask @SyntaxNode to weigh in on that. I would like to hope that we can obsolete any special support there for deals as we migrate LFV functionality into the main auction endpoint.

@ShriprasadM
Copy link
Contributor Author

Thanks @bretg for an update. @SyntaxNode can you update on LFV part?

Another Question: What is the way one can prioritise the deals for non-lfv (banner, native) using existing flags, in both the cases server side and JS side? @bretg / @SyntaxNode

@bretg
Copy link
Contributor

bretg commented Dec 14, 2022

What is the way one can prioritise the deals for non-lfv (banner, native) using existing flags, in both the cases server side and JS side?

There's not a silver bullet here.

  1. PBJS - https://docs.prebid.org/dev-docs/publisher-api-reference/setConfig.html#configure-send-bids-control
pbjs.setConfig({
  sendBidsControl: {
    dealPrioritization: true
  }
});
  1. PBS invoked from Prebid.js
pbjs.setConfig({
  s2sConfig: {
     ...
     extPrebid: {
         targeting: {
             preferdeals: true
         }
     }
  }
});

It wouldn't be impossible to have the PBS bid adapter add this logic when sendBidsControl. dealPrioritization is set.

  1. PBS invoked from SDK

host company needs to add ext.prebid.targeting. preferdeals: true to the 'top-level' stored request

  1. PBS invoked from AMP

host company needs to add ext.prebid.targeting. preferdeals: true in the AMP stored request

@ShriprasadM
Copy link
Contributor Author

Thanks @bretg.

  1. Which targeting key, should be used to prioritise deals on GAM side in case of non-lfv format?

@bretg
Copy link
Contributor

bretg commented Dec 16, 2022

Which targeting key, should be used to prioritise deals on GAM side in case of non-lfv format?

Not following the question @ShriprasadM .

Prebid.js sends the hb_deal (or hb_deal_BIDDER) key-value pair to GAM. That's it.

Prioritizing in GAM is in how you set up the line items. https://docs.prebid.org/adops/deals.html

@bretg
Copy link
Contributor

bretg commented Dec 22, 2022

What's left on this issue @ShriprasadM ?

@bretg bretg moved this from Triage to Clarify Request in Prebid Server Prioritization Dec 22, 2022
@bretg
Copy link
Contributor

bretg commented Feb 7, 2023

Are we good here @ShriprasadM ?

Deal support on the /video endpoint is a separate thing, not related to deal support on the main /auction endpoint. The /video endpoint is deprecated.

@ShriprasadM
Copy link
Contributor Author

Yes @bretg . Thanks.

@bretg bretg closed this as completed Mar 28, 2023
@github-project-automation github-project-automation bot moved this from Clarify Request to Done in Prebid Server Prioritization Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants