Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create a reviewer checklist #3307

Open
bretg opened this issue Nov 17, 2023 · 1 comment
Open

create a reviewer checklist #3307

bretg opened this issue Nov 17, 2023 · 1 comment

Comments

@bretg
Copy link
Contributor

bretg commented Nov 17, 2023

As discussed in committee, we should make public the checklists that our reviewing teams utilize when reviewing the code for a bid adapter.

e.g.

  • verify email contact works
  • no fully dynamic hosts
  • geographic host parameters cannot be required
  • no direct use of HTTP
  • (PBS-Java) if the ORTB is just forwarded to the endpoint, use the generic adapter
  • etc
@bretg bretg changed the title Document reviewer checklist create a reviewer checklist Nov 17, 2023
@bretg
Copy link
Contributor Author

bretg commented Dec 1, 2023

Suggested location: docs/reviewers.md

@bretg bretg moved this from Triage to Ready for Dev in Prebid Server Prioritization Dec 1, 2023
@bretg bretg mentioned this issue Jan 3, 2024
Closed
@AntoxaAntoxic AntoxaAntoxic mentioned this issue Oct 21, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Prebid Server Prioritization
Status: Ready for Dev
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bretg