Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Reviewer Checklist #3520

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Add Reviewer Checklist #3520

merged 3 commits into from
Oct 28, 2024

Conversation

AntoxaAntoxic
Copy link
Collaborator

@AntoxaAntoxic AntoxaAntoxic commented Oct 21, 2024 •
edited
Loading

🔧 Type of changes

  • new bid adapter
  • update bid adapter
  • new feature
  • new analytics adapter
  • new module
  • bugfix
  • documentation
  • configuration
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

prebid/prebid-server#3307

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@AntoxaAntoxic AntoxaAntoxic self-assigned this Oct 21, 2024
@Compile-Ninja Compile-Ninja merged commit 79669e6 into master Oct 28, 2024
4 checks passed
@Compile-Ninja Compile-Ninja deleted the reviewer-checklist branch October 28, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Compile-Ninja Compile-Ninja Compile-Ninja approved these changes

Assignees

@AntoxaAntoxic AntoxaAntoxic

Labels
do not port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntoxaAntoxic @Compile-Ninja