Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndexExchange vs ix #657

Closed
bretg opened this issue Aug 21, 2018 · 4 comments
Closed

IndexExchange vs ix #657

bretg opened this issue Aug 21, 2018 · 4 comments

Comments

@bretg
Copy link
Contributor

bretg commented Aug 21, 2018

For PBJS 1.0, IndexExchange changed the name of their PBJS adapter to ix.

This is causing compatibility issues with calling PBS via the prebidServerBidAdapter. Two specific issues:

  1. 'ix' isn't recognized on the Prebid Server side
  2. the siteId parameter is defined on the client side, but the server expects siteID
@bretg
Copy link
Contributor Author

bretg commented Aug 21, 2018

@prebid/indexexchange - let us know if you're working on this or have any input as to a preferred solution.

In the meantime, we discussed this issue today and propose to copy the existing 'IndexExchange' Prebid Server adapter and make two changes:

  1. name the new adapter ix
  2. have the new adapter accept siteId rather than siteID

@dbemiller
Copy link
Contributor

dbemiller commented Oct 2, 2018

A few related tickets redirect here... so linking these comments for visibility:

I've heard nothing about this personally... but technically, according to the docs we don't even support 0.x anymore: http://prebid.org/dev-docs/bidders.html

So at this point it should be safe to just make the breaking change and rename the Index adapter to ix.

@akira28
Copy link

akira28 commented Oct 2, 2018

Seems that they are working on it on their fork: indexexchange@aeb02bb

@dbemiller
Copy link
Contributor

This has been merged & should be resolved now.

katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this issue Dec 1, 2020
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this issue Dec 2, 2020
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this issue Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants