Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PubMatic bidder doc file and in-app video to bidder info #1255

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Add PubMatic bidder doc file and in-app video to bidder info #1255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions docs/bidders/pubmatic.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# PubMatic Bidder

## Test Request

The following test parameters can be used to verify that Prebid Server is working properly with the
PubMatic adapter. This example includes an `imp` object with an PubMatic test publisher ID, ad slot,
and sizes that would match with the test creative.

Copy link
Contributor

@guscarreon guscarreon Apr 10, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we ok with only mentioning two out of the four parameters that the imp.ext object can come with in this example? What about a video imp example? Will that be left for another PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used AppNexus' doc file as a template:
https://github.com/prebid/prebid-server/blob/master/docs/bidders/appnexus.md

I can add info for video in another PR

```
"imp":[
{
"id":“"some-impression-id”,
"banner":{
"format":[
{
"w":300,
"h":250
},
{
"w":300,
"h":600
}
]
},
"ext":{
"pubmatic":{
"publisherId":“156276”,
"adSlot":"pubmatic_test"
}
}
}
]
```
1 change: 1 addition & 0 deletions static/bidder-info/pubmatic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ capabilities:
app:
mediaTypes:
- banner
- video
site:
mediaTypes:
- banner
Expand Down