-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass Through First Party Context Data #1479
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
43bd697
Pass Through First Party Context Data
SyntaxNode df0fbc9
Remove Manual Test Harness
SyntaxNode dd0c680
Extract Bidder Special Case Handling To Method
SyntaxNode 715bfa1
Fixed Wrong Naming
SyntaxNode 079426e
Better Exchange Test File Names
SyntaxNode a8c66ed
Renamed ExtRequestFirstPartyDataContext
SyntaxNode 1bc35a4
Code Review Feedback
SyntaxNode 15f4a9c
Replace Placeholder Description
SyntaxNode 7e1a7e6
Added Validation Test Coverage
SyntaxNode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
endpoints/openrtb2/sample-requests/first-party-data/valid-context-allowed.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| { | ||
| "description": "xxx", | ||
|
|
||
| "requestPayload": { | ||
| "id": "some-request-id", | ||
| "site": { | ||
| "page": "test.somepage.com" | ||
| }, | ||
| "imp": [{ | ||
| "id": "some-imp-id", | ||
| "banner": { | ||
| "format": [{ | ||
| "w": 600, | ||
| "h": 500 | ||
| }, { | ||
| "w": 300, | ||
| "h": 600 | ||
| }] | ||
| }, | ||
| "ext": { | ||
| "appnexus": { | ||
| "placementId": 12883451 | ||
| }, | ||
| "context": { | ||
| "data": { | ||
| "keywords": "prebid server example" | ||
| } | ||
| } | ||
| } | ||
| }] | ||
| } | ||
| } | ||
173 changes: 173 additions & 0 deletions
173
exchange/exchangetest/firstpartydata-imp-ext-multiple-bidders.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,173 @@ | ||
| { | ||
| "incomingRequest": { | ||
| "ortbRequest": { | ||
| "id": "some-request-id", | ||
| "site": { | ||
| "page": "test.somepage.com" | ||
| }, | ||
| "imp": [{ | ||
| "id": "some-imp-id", | ||
| "banner": { | ||
| "format": [{ | ||
| "w": 600, | ||
| "h": 500 | ||
| }, { | ||
| "w": 300, | ||
| "h": 600 | ||
| }] | ||
| }, | ||
| "ext": { | ||
| "appnexus": { | ||
| "placementId": 1 | ||
| }, | ||
| "rubicon": { | ||
| "accountId": 1, | ||
| "siteId": 2, | ||
| "zoneId": 3 | ||
| }, | ||
| "context": { | ||
| "data": { | ||
| "keywords": "prebid server example" | ||
| } | ||
| } | ||
| } | ||
| }] | ||
| } | ||
| }, | ||
| "outgoingRequests": { | ||
| "appnexus": { | ||
| "expectRequest": { | ||
| "ortbRequest": { | ||
| "id": "some-request-id", | ||
| "site": { | ||
| "page": "test.somepage.com" | ||
| }, | ||
| "imp": [{ | ||
| "id": "some-imp-id", | ||
| "banner": { | ||
| "format": [{ | ||
| "w": 600, | ||
| "h": 500 | ||
| }, { | ||
| "w": 300, | ||
| "h": 600 | ||
| }] | ||
| }, | ||
| "ext": { | ||
| "bidder": { | ||
| "placementId": 1 | ||
| }, | ||
| "context": { | ||
| "data": { | ||
| "keywords": "prebid server example" | ||
| } | ||
| } | ||
| } | ||
| }] | ||
| }, | ||
| "bidAdjustment": 1.0 | ||
| }, | ||
| "mockResponse": { | ||
| "pbsSeatBid": { | ||
| "pbsBids": [{ | ||
| "ortbBid": { | ||
| "id": "apn-bid", | ||
| "impid": "some-imp-id", | ||
| "price": 0.3, | ||
| "w": 200, | ||
| "h": 500, | ||
| "crid": "creative-1" | ||
| }, | ||
| "bidType": "banner" | ||
| }] | ||
| } | ||
| } | ||
| }, | ||
| "rubicon": { | ||
| "expectRequest": { | ||
| "ortbRequest": { | ||
| "id": "some-request-id", | ||
| "site": { | ||
| "page": "test.somepage.com" | ||
| }, | ||
| "imp": [{ | ||
| "id": "some-imp-id", | ||
| "banner": { | ||
| "format": [{ | ||
| "w": 600, | ||
| "h": 500 | ||
| }, { | ||
| "w": 300, | ||
| "h": 600 | ||
| }] | ||
| }, | ||
| "ext": { | ||
| "bidder": { | ||
| "accountId": 1, | ||
| "siteId": 2, | ||
| "zoneId": 3 | ||
| }, | ||
| "context": { | ||
| "data": { | ||
| "keywords": "prebid server example" | ||
| } | ||
| } | ||
| } | ||
| }] | ||
| }, | ||
| "bidAdjustment": 1.0 | ||
| }, | ||
| "mockResponse": { | ||
| "pbsSeatBid": { | ||
| "pbsBids": [{ | ||
| "ortbBid": { | ||
| "id": "rubi-bid", | ||
| "impid": "some-imp-id", | ||
| "price": 0.4, | ||
| "w": 200, | ||
| "h": 500, | ||
| "crid": "creative-2" | ||
| }, | ||
| "bidType": "banner" | ||
| }] | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "response": { | ||
| "bids": { | ||
| "id": "some-request-id", | ||
| "seatbid": [{ | ||
| "seat": "appnexus", | ||
| "bid": [{ | ||
| "id": "apn-bid", | ||
| "impid": "some-imp-id", | ||
| "price": 0.3, | ||
| "w": 200, | ||
| "h": 500, | ||
| "crid": "creative-1", | ||
| "ext": { | ||
| "prebid": { | ||
| "type": "banner" | ||
| } | ||
| } | ||
| }] | ||
| }, { | ||
| "seat": "rubicon", | ||
| "bid": [{ | ||
| "id": "rubi-bid", | ||
| "impid": "some-imp-id", | ||
| "price": 0.4, | ||
| "w": 200, | ||
| "h": 500, | ||
| "crid": "creative-2", | ||
| "ext": { | ||
| "prebid": { | ||
| "type": "banner" | ||
| } | ||
| } | ||
| }] | ||
| }] | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This throws a validation exception currently.