Always use fallback GVL for TCF1 #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
changed the title
SyntaxNode
reviewed
Jan 23, 2021
| return func(ctx context.Context, vendorListVersion uint16) (vendorlist.VendorList, error) { | ||
| return fallback, nil | ||
| } | ||
| } |
There was a problem hiding this comment.
How about combining the two tcfSpecVersion == tcf1SpecVersion conditions to eliminate the duplication?
guscarreon
requested changes
Jan 26, 2021
| @@ -217,7 +217,7 @@ func (cfg *GDPR) validate(errs []error) []error { | |||
| errs = append(errs, fmt.Errorf("gdpr.amp_exception has been discontinued and must be removed from your config. If you need to disable GDPR for AMP, you may do so per-account (gdpr.integration_enabled.amp) or at the host level for the default account (account_defaults.gdpr.integration_enabled.amp)")) | |||
| } | |||
| if cfg.TCF1.FetchGVL == true { | |||
| glog.Warning("gdpr.tcf1.fetch_gvl is deprecated and will be removed in a future version, at which point TCF1 will always use the fallback GVL") | |||
| errs = append(errs, fmt.Errorf("gdpr.tcf1.fetch_gvl has been discontinued and must be removed from your config. TCF1 will always use the fallback GVL going forward")) | |||
There was a problem hiding this comment.
Newly added conditional true branch seems to not have coverage. Also, in the config/config_test.go file, can we unify TestNegativeVendorID(t *testing.T) and TestOverflowedVendorID(t *testing.T) into a single table-test?
hhhjort
previously approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.