Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPD: Allow imp.ext.data To Passthrough To Adapters #1765

Merged
merged 3 commits into from
Mar 23, 2021

Conversation

SyntaxNode
Copy link
Contributor

@SyntaxNode SyntaxNode commented Mar 19, 2021

All json fields within request.imp[].ext are expected to be bidder names. Exemptions need to be made for special cases, such as for First Party Data. Other parts of code enforce the bidder name "data" is forbidden making this a safe operation.

Implements #1768

Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice simple addition to the list of exceptions. Looks good to me.

Copy link
Collaborator

@bsardo bsardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo merged commit 080843b into prebid:master Mar 23, 2021
@SyntaxNode SyntaxNode deleted the fpd_data branch September 2, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants