Remove old race condition tests #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansinahar
changed the title
VeronikaSolovei9
approved these changes
Aug 16, 2021
|
@guscarreon Please open a docs PR to update the new bidder guide before merging this in. |
|
Documentaion PR: |
wwwyyy
pushed a commit
to wwwyyy/prebid-server
that referenced
this pull request
Aug 20, 2021
… prebid-master * 'master' of https://github.com/prebid/prebid-server: Update Viper (prebid#1969) /cookie_sync Endpoint Rewrite (prebid#1879) New Adapter: IQZone (prebid#1964) Remove old race conidtion tests (prebid#1958) Remove time.Now() as the first parameter of NewRates() (prebid#1953) # Conflicts: # config/config.go # usersync/usersyncers/syncer_test.go
jizeyopera
pushed a commit
to operaads/prebid-server
that referenced
this pull request
Oct 13, 2021
shunj-nb
pushed a commit
to ParticleMedia/prebid-server
that referenced
this pull request
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #1756 added a new test in
adapters/adapterstest/test_json.goto assert no data races happen when calling theMakeRequests()implementation of every bidder adapter in this repository. This pull request removes the old data race detection functionality found in prebid-server core as well as the supporting JSON files located inside every adapter'sadapters/fooadapter/adftest/params/racedirectory.