IQzone Bidder Adapter: add new bid param #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhhjort
reviewed
Sep 10, 2021
adapters/iqzone/iqzone.go
Outdated
| for i, imp := range request.Imp { | ||
| reqCopy.Imp = []openrtb2.Imp{imp} | ||
|
|
||
| if err = json.Unmarshal(reqCopy.Imp[i].Ext, &bidderExt); err != nil { |
There was a problem hiding this comment.
should this be json.Unmarshal(reqCopy.Imp[0].Ext, &bidderExt)? Line 35 above you have defined reqCopy.Imp[] to have only one entry in its array.
There was a problem hiding this comment.
oh, thanks for finding this problem, we fixed it
hhhjort
reviewed
Sep 13, 2021
| for _, imp := range request.Imp { | ||
| reqCopy.Imp = []openrtb2.Imp{imp} | ||
|
|
||
| if err = json.Unmarshal(reqCopy.Imp[0].Ext, &bidderExt); err != nil { |
There was a problem hiding this comment.
Declaring bidderExt and iqzoneExt at the start rather than in the loop, means they are persistent. This could potentially cause an issue if a field that exists in imp[0] is omitted from imp[1], the Unmarshal call will not zero out that parameter and thus you could see it where it does not belong.
There was a problem hiding this comment.
Thanks for finding this bug and explaining it. We have fixed this.
VeronikaSolovei9
previously approved these changes
Sep 14, 2021
VeronikaSolovei9
approved these changes
Sep 15, 2021
jizeyopera
pushed a commit
to operaads/prebid-server
that referenced
this pull request
Oct 13, 2021
add IQZone adapter
shunj-nb
pushed a commit
to ParticleMedia/prebid-server
that referenced
this pull request
Nov 8, 2022
add IQZone adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated doc - prebid/prebid.github.io#3250