Rubicon adapter: accept accountId, siteId, zoneId as strings #2110
Conversation
openrtb_ext/imp_rubicon.go
Outdated
| ZoneId int `json:"zoneId"` | ||
| AccountId json.RawMessage `json:"accountId"` | ||
| SiteId json.RawMessage `json:"siteId"` | ||
| ZoneId json.RawMessage `json:"zoneId"` |
There was a problem hiding this comment.
Would it be easier to use json.Number instead? Please refer to this PR: https://github.com/prebid/prebid-server/pull/2105/files
There was a problem hiding this comment.
Yeah, thanks for suggestion!
There was a problem hiding this comment.
Thank you for changing the code!
May I ask you to add json test where imp.ext.{accountId/siteId/zoneId} have string values? Similar to what you already have in exemplary, but with strings instead?
| siteId, err := rubiconExt.SiteId.Int64() | ||
| if err != nil { | ||
| errs = append(errs, err) | ||
| continue |
There was a problem hiding this comment.
This is just for my own understanding, but is there a chance that the error we can get back is bad enough that we wouldn't want to continue execution?
I see this style of error handling in a lot of places in this file, so I was just wondering.
There was a problem hiding this comment.
In most cases we would like to continue execution.
|
Hi guys, hope you had a good holidays! |
|
Documentation updates related pr: prebid/prebid.github.io#3496 |
* 'master' of https://github.com/wwwyyy/prebid-server: GDPR: pass geo based on special feature 1 opt-in (prebid#2122) Adyoulike: Fix adapter errors if no content (prebid#2134) Update adyoulike.yaml (prebid#2131) Add ORTB 2.4 schain support (prebid#2108) Stored response fetcher (with new func for stored resp) (prebid#2099) Adot: Add OpenRTB macros resolution (prebid#2118) Rubicon adapter: accept accountId, siteId, zoneId as strings (prebid#2110) Operaads: support multiformat request (prebid#2121) Update go-gdpr to v1.11.0 (prebid#2125) Adgeneration: Update request to include device and app related info in headers and query params (prebid#2109) Adnuntius: Read device information from ortb Request (prebid#2112) New Adapter: apacdex and Remove Adapter: valueimpression (prebid#2097) New Adapter: Compass (prebid#2102) Orbidder: bidfloor currency handling (prebid#2093)
…solution added in addition to a deprecation warning (prebid#2110)
Changes from prebid/prebid-server-java#1627