Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adkernel: static endpoint host #2169

Merged
merged 3 commits into from
Mar 7, 2022
Merged

Adkernel: static endpoint host #2169

merged 3 commits into from
Mar 7, 2022

Conversation

ckbo3hrk
Copy link
Contributor

@ckbo3hrk ckbo3hrk commented Mar 1, 2022

Switched to static adkernel host instead of publisher-side configured domains to address #2127

@bsardo bsardo requested a review from hhhjort March 1, 2022 18:29
@bsardo bsardo requested a review from AlexBVolcy March 1, 2022 18:29
@hhhjort
Copy link
Collaborator

hhhjort commented Mar 1, 2022 •
edited
Loading

You should drop host as a required bidder parameter, and probably drop it completely, unless your bidder is making some use of the host parameter being passed, even though your adapter is ignoring it.

That would be /static/bidder-params/adkernel.json

AlexBVolcy
AlexBVolcy reviewed Mar 1, 2022
View reviewed changes
Copy link
Contributor

@AlexBVolcy AlexBVolcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I won't approve until other comments are addressed (i.e. removing host from bidder params)

hhhjort
hhhjort approved these changes Mar 2, 2022
View reviewed changes
Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhhjort hhhjort merged commit 4e8c814 into prebid:master Mar 7, 2022
@ckbo3hrk ckbo3hrk deleted the adkernel_static_host branch March 7, 2022 19:55
@SerhiiNahornyi SerhiiNahornyi mentioned this pull request Mar 14, 2022
Merged
pm-nilesh-chate pushed a commit to PubMatic-OpenWrap/prebid-server that referenced this pull request Mar 30, 2022
@ckbo3hrk @pm-nilesh-chate
Adkernel: static endpoint host (prebid#2169)
9810ae4 
* Adkernel: switch to static server host

* Actualizing adkernel adaptor parameters

Updating according to prebid#2169 (comment)
jorgeluisrocha pushed a commit to jwplayer/prebid-server that referenced this pull request Sep 28, 2022
@ckbo3hrk @jorgeluisrocha
Adkernel: static endpoint host (prebid#2169)
5922f64 
* Adkernel: switch to static server host

* Actualizing adkernel adaptor parameters

Updating according to prebid#2169 (comment)
shunj-nb pushed a commit to ParticleMedia/prebid-server that referenced this pull request Nov 8, 2022
@ckbo3hrk @shunj-nb
Adkernel: static endpoint host (prebid#2169)
0c00471 
* Adkernel: switch to static server host

* Actualizing adkernel adaptor parameters

Updating according to prebid#2169 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexBVolcy AlexBVolcy AlexBVolcy approved these changes

@hhhjort hhhjort hhhjort approved these changes

Assignees

@hhhjort hhhjort

@AlexBVolcy AlexBVolcy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckbo3hrk @hhhjort @AlexBVolcy