New Adapter: freewheelssp #2392

mwang-sticky · 2022-09-27T07:44:15Z

No description provided.

adapters/freewheelssp/freewheelssp.go

adapters/freewheelssp/freewheelssp_test.go

exchange/adapter_builders.go

AlexBVolcy

Could you please link your docs PR?

AlexBVolcy · 2022-10-11T16:28:11Z

adapters/freewheelssp/freewheelssp.go

+
+	if response.StatusCode != http.StatusOK {
+		return nil, []error{&errortypes.BadServerResponse{
+			Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info", response.StatusCode),


Is there a way to cover this error case with tests?

AlexBVolcy · 2022-10-12T19:30:12Z

There is a PR #2370 that is being merged today that will cause conflicts to new adapter PRs.

To resolve these conflicts, you'll need to do the following:

In freewheelssp.go, update the Builder() function signature to include a new parameter server config.Server

In freewheelssp_test.go, update any test that includes a call to Builder() to pass a config.Server object, to that call (i.e. config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "datacenter"})

After the merge, you can look at other adapters to see how the server object is implemented as an example.

SyntaxNode

Looks good. Thank you for the fixes.

FYI: Prebid Server has 6 characters of guaranteed bidder name uniqueness. For freehweelssp that would be freewh. I'm sharing this because your adapter name is freewheelssp instead of just freewheel, so if you plan to add other adapters within the freewheel family in the future (ie freewheel123), the targeting keys may not be unique between them. Not a problem, just wanted you to be aware.

SyntaxNode · 2022-10-12T19:30:56Z

static/bidder-info/freewheelssp.yaml

+      - video
+userSync:
+  redirect:
+    url: "https://ads.stickyadstv.com/pbs-user-sync?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&r={{.RedirectURL}}"


I tested the user sync endpoint and discovered it returns html instead of a 302 redirect. Should be defined as an iframe sync instead of a redirect?

FW-113142 modify code according review (prebid#2) FW-113142 1.503-bid-resposne. 2.Add server to builder (prebid#3) * modify code according review * FW-113142 1.503-bid-resposne. 2.Add server to builder

bsardo · 2022-10-19T17:21:39Z

Hi @mwang-sticky, we'll check out your changes shortly. Also, if you don't mind, could you please avoid force pushing after the PR has been reviewed? We prefer you just push another commit with your changes as this helps the reviewers save a lot of time since they often only need to review the delta. And if conflicts arise they can be resolved by merging with master instead of rebasing with a force push 🙂. Thanks again for your contribution.

AlexBVolcy

This looks good, but I still don't see a link to your docs PR, could you please add this as a comment on this PR

mwang-sticky · 2022-10-20T03:47:14Z

@bsardo @AlexBVolcy
Sorry for force commit to resolve some conflict,
I add the doc request: prebid/prebid.github.io#4094
however our prebid js still use freeweel-ssp which is not supported by GAM, then prebid-go has changed to new biddercode freewheelssp, please tell me how can I solve this difference, does it impact prebid integration?

should I change the filename and default biddercode to freewheelssp, and add aliasCode: freewheel-ssp

I look forward your help.

bsardo · 2022-10-20T22:11:12Z

Hi @mwang-sticky, we strongly prefer prebid.js and PBS use the same bidder codes. If you use different biddercodes it confuses publishers and leads to confusing documentation.

It sounds like you want to move away from freewheel-ssp to freewheelssp with one of the main reasons being the new name is supported by GAM. Can you confirm?

If your long term goal is to standardize on freewheelssp, then we recommend one of the following two courses of action:

If you plan to update prebid.js with the new name freewheelssp in the immediate future, then you should be ok just supporting freewheelssp in PBS since you'll effectively be forcing publishers to update to the new name even if they just want to use prebid.js with an imminent prebid.js update.
If you plan to update prebid.js with the new name eventually (say in 2023 or beyond), then we recommend adding an alias in PBS so publishers can easily switch between the two names until prebid.js catches up. In order to do this, you would create a hardcoded alias where you have two bidder names of type openrtb_ext.BidderName and a single adapter of type adapters.Builder that maps to each of the two bidder names. See PR#2302 as an example of how to add a hardcoded alias in PBS.

I hope this helps. If I misunderstood your intention, let me know.

add old bidder go name

add old bidder code

mwang-sticky · 2022-10-24T02:41:52Z

It sounds like you want to move away from freewheel-ssp to freewheelssp with one of the main reasons being the new name is supported by GAM. Can you confirm?

Yes, some of our publishers asked us to change the old biddercode.

If your long term goal is to standardize on freewheelssp, then we recommend one of the following two courses of action:

Thanks for your good suggestion. I add the old bidder code in go adapter.
Our js team has add the new bidder name, however because some of our clients has used the old prebid js, then we don't want to impact a lot. prebid/Prebid.js#9093

Does this change work for prebid go/js integration? because the bidder names are conflicted

bsardo · 2022-10-25T18:08:20Z

Hi @mwang-sticky, I'm sorry I'm not able to confirm your PBS and prebid.js integration works as that is outside of the scope of our team. I do believe though that as long as prebid.js and PBS support the same bidder parameters for your bidder and each has support for both bidder codes, the integration should work.

mwang-sticky · 2022-10-26T05:09:44Z

@bsardo
As the biddercode is conflicted, how can I to solve this error

bidders_validate_test.go:62: Error Trace: bidders_validate_test.go:62 Error: "10" is not less than or equal to "6" Test: TestBidderUniquenessGatekeeping
Thanks,

SyntaxNode · 2022-10-27T18:24:40Z

@bsardo As the biddercode is conflicted, how can I to solve this error

bidders_validate_test.go:62: Error Trace: bidders_validate_test.go:62 Error: "10" is not less than or equal to "6" Test:TestBidderUniquenessGatekeeping Thanks,

This is to ensure the bidder name is unique enough in targeting keys. The uniqueness constraint is not usually important for aliases. So long as a bid from freewheelssp and freewheel-ssp are the same, then you can add an exception along side Triplelift and Adkernel. ie:

if bidder != BidderTripleliftNative && bidder != BidderAdkernelAdn && bidder != BidderFreewheelSSPOld {

mwang-sticky · 2022-10-31T04:18:37Z

if bidder != BidderTripleliftNative && bidder != BidderAdkernelAdn && bidder != BidderFreewheelSSPOld {
I updated this, should I update other info？

AlexBVolcy

I'm ready to approve, but @bsardo I just want to confirm how we want to go about PRs that are throwing this gofmt error in the Github validation?

bsardo · 2022-11-01T13:56:58Z

Hi @mwang-sticky, can you merge with master when you get a chance? Your code is failing the go 1.19 validation checks due to go fmt changes that were introduced with the recent upgrade to go 1.19 on master.

mwang-sticky · 2022-11-02T06:21:27Z

@bsardo I synced the master to my branch, thanks for your reminder.

VeronikaSolovei9 · 2022-11-09T23:36:43Z

adapters/freewheelssp/freewheelssp.go

+
+type RequestImpExt struct {
+	ZoneId int `json:"zoneId"`
+}


No need ot specify imp ext here. It's already specified in openrtb_ext/imp_freewheelssp.go

adapters/freewheelssp/freewheelssp.go

VeronikaSolovei9

Thank you for addressing comments, lgtm

AlexBVolcy

LGTM

Co-authored-by: Kai Zhang <kaizhang@freewheel.com>

SyntaxNode changed the title ~~add freewheelssp go adapter~~ New Adapter: freewheelssp Sep 27, 2022

SyntaxNode self-requested a review September 27, 2022 16:25

SyntaxNode self-assigned this Sep 27, 2022

SyntaxNode reviewed Sep 27, 2022

View reviewed changes

bsardo self-requested a review September 27, 2022 17:37

bsardo self-assigned this Sep 27, 2022

SyntaxNode added the port to java label Oct 3, 2022

bsardo requested a review from AlexBVolcy October 10, 2022 17:27

bsardo assigned AlexBVolcy and unassigned SyntaxNode Oct 10, 2022

AlexBVolcy reviewed Oct 11, 2022

View reviewed changes

SyntaxNode reviewed Oct 12, 2022

View reviewed changes

update endpoint to static yaml

39fd190

FW-113142 modify code according review (prebid#2) FW-113142 1.503-bid-resposne. 2.Add server to builder (prebid#3) * modify code according review * FW-113142 1.503-bid-resposne. 2.Add server to builder

mwang-sticky force-pushed the freewheel-go-adapter branch from bd7bf6c to 39fd190 Compare October 17, 2022 09:04

update import package

e8357ff

AlexBVolcy reviewed Oct 19, 2022

View reviewed changes

mwang-sticky added 3 commits October 23, 2022 10:16

Update adapter_builders.go

c52533e

add old bidder go name

Update bidders.go

4779284

add old bidder code

add old biddercode support

ef07818

mwang-sticky added 3 commits October 25, 2022 14:36

add freewheelssp old data

2514b7c

use the freewheel-ssp code

9b5e3a1

Delete freewheelsspold.yaml

7f749ad

skip freewheelold bidder check

2ead09c

AlexBVolcy reviewed Oct 31, 2022

View reviewed changes

Merge branch 'prebid:master' into freewheel-go-adapter

679e695

AlexBVolcy previously approved these changes Nov 2, 2022

View reviewed changes

bsardo requested review from VeronikaSolovei9 and removed request for bsardo November 8, 2022 18:29

bsardo assigned VeronikaSolovei9 and unassigned bsardo Nov 8, 2022

VeronikaSolovei9 reviewed Nov 10, 2022

View reviewed changes

mwang-sticky added 2 commits November 10, 2022 16:00

Merge branch 'prebid:master' into freewheel-go-adapter

b667a7b

remove useless struct

f229580

mwang-sticky dismissed AlexBVolcy’s stale review via f229580 November 11, 2022 06:29

VeronikaSolovei9 approved these changes Nov 14, 2022

View reviewed changes

AlexBVolcy approved these changes Nov 15, 2022

View reviewed changes

bsardo merged commit d912d2a into prebid:master Nov 15, 2022

shunj-nb pushed a commit to ParticleMedia/prebid-server that referenced this pull request Jan 31, 2023

New Adapter: freewheelssp (prebid#2392)

80941b8

Co-authored-by: Kai Zhang <kaizhang@freewheel.com>

bretg mentioned this pull request Feb 14, 2023

Port freewheelssp adapter prebid/prebid-server-java#2168

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Adapter: freewheelssp #2392

New Adapter: freewheelssp #2392

mwang-sticky commented Sep 27, 2022

AlexBVolcy left a comment

AlexBVolcy Oct 11, 2022

AlexBVolcy commented Oct 12, 2022

SyntaxNode left a comment •

edited

Loading

SyntaxNode Oct 12, 2022

bsardo commented Oct 19, 2022

AlexBVolcy left a comment

mwang-sticky commented Oct 20, 2022 •

edited

Loading

bsardo commented Oct 20, 2022

mwang-sticky commented Oct 24, 2022 •

edited

Loading

bsardo commented Oct 25, 2022 •

edited

Loading

mwang-sticky commented Oct 26, 2022

SyntaxNode commented Oct 27, 2022

mwang-sticky commented Oct 31, 2022

AlexBVolcy left a comment

bsardo commented Nov 1, 2022

mwang-sticky commented Nov 2, 2022

VeronikaSolovei9 Nov 9, 2022 •

edited

Loading

VeronikaSolovei9 left a comment

AlexBVolcy left a comment

New Adapter: freewheelssp #2392

New Adapter: freewheelssp #2392

Conversation

mwang-sticky commented Sep 27, 2022

AlexBVolcy left a comment

Choose a reason for hiding this comment

AlexBVolcy Oct 11, 2022

Choose a reason for hiding this comment

AlexBVolcy commented Oct 12, 2022

SyntaxNode left a comment • edited Loading

Choose a reason for hiding this comment

SyntaxNode Oct 12, 2022

Choose a reason for hiding this comment

bsardo commented Oct 19, 2022

AlexBVolcy left a comment

Choose a reason for hiding this comment

mwang-sticky commented Oct 20, 2022 • edited Loading

bsardo commented Oct 20, 2022

mwang-sticky commented Oct 24, 2022 • edited Loading

bsardo commented Oct 25, 2022 • edited Loading

mwang-sticky commented Oct 26, 2022

SyntaxNode commented Oct 27, 2022

mwang-sticky commented Oct 31, 2022

AlexBVolcy left a comment

Choose a reason for hiding this comment

bsardo commented Nov 1, 2022

mwang-sticky commented Nov 2, 2022

VeronikaSolovei9 Nov 9, 2022 • edited Loading

Choose a reason for hiding this comment

VeronikaSolovei9 left a comment

Choose a reason for hiding this comment

AlexBVolcy left a comment

Choose a reason for hiding this comment

SyntaxNode left a comment •

edited

Loading

mwang-sticky commented Oct 20, 2022 •

edited

Loading

mwang-sticky commented Oct 24, 2022 •

edited

Loading

bsardo commented Oct 25, 2022 •

edited

Loading

VeronikaSolovei9 Nov 9, 2022 •

edited

Loading