VISX: Add string support to UID #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating UID to support both integer and string. - Updated schema to support string and integer types - Added regex to schema for UID format validation - Added new test params
guscarreon
reviewed
Jan 1, 2023
| `{"uid": "-1"}`, | ||
| `{"uid": "232af"}`, | ||
| `{"uid": "af213"}`, | ||
| `{"uid": "af"}`, |
There was a problem hiding this comment.
Nitpicks:
- Can we add an
intthat comes with acharin here?
43 var invalidParams = []string{
44 `null`,
45 `nil`,
46 ``,
47 `[]`,
48 `true`,
49 `2`,
50 `{"size":12345678}`,
51 `{"size":""}`,
52 `{"uid": "-1"}`,
53 `{"uid": "232af"}`,
+ `{"uid": 232af}`,
54 `{"uid": "af213"}`,
55 `{"uid": "af"}`,
56 `{"size": true}`,
57 `{"uid": true, "size":"1234567"}`,
58 }
- And also add a
stringunit tests on thevalidParamsside?
35 var validParams = []string{
36 `{"uid":13245}`,
+ `{"uid":"13245"}`,
37 `{"uid":13245, "size": [10,5]}`,
38 `{"uid":13245, "other_optional": true}`,
39 }
There was a problem hiding this comment.
Hi @guscarreon,
Thanks for the feedback.
On #1, I'm not sure if it's still necessary given that case would be an invalid JSON altogether, and parsing should fail already, without reaching schema validation.
As for #2, make sense, just to make sure it's covered as well.
- Added additional valid `uid` test data with a string-wrapped int
guscarreon
reviewed
Jan 5, 2023
guscarreon
approved these changes
Jan 9, 2023
guscarreon
reviewed
Jan 9, 2023
| @@ -5,7 +5,8 @@ | |||
| "type": "object", | |||
| "properties": { | |||
| "uid": { | |||
| "type": "integer", | |||
| "type": ["integer", "string"], | |||
There was a problem hiding this comment.
@deubaka can we reflect this change in the bid-param section of the docs please?
There was a problem hiding this comment.
Good catch, thanks! We've added the corresponding updates in this PR, prebid/prebid.github.io#4273.
This was referenced Jan 12, 2023
shunj-nb
pushed a commit
to ParticleMedia/prebid-server
that referenced
this pull request
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating UID to support both integer and string.