Kargo: Normalize placementId naming #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| `{"adSlotID": ""}`, | ||
| `{"adSlotID": "11523"}`, | ||
| } | ||
|
|
||
| var invalidParams = []string{ | ||
| `{"placementId": 42}`, | ||
| `{"placementId": }`, | ||
| `{"placementID": "32321"}`, |
There was a problem hiding this comment.
Just curious, What should be the behaviour if both placementId and adSlotID are defined?
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
gargcreation1992
requested changes
May 22, 2023
|
@gargcreation1992 thanks Ashish. Just added an invalid test parameter for when both are set. |
| @@ -49,4 +49,5 @@ var invalidParams = []string{ | |||
| `{"adSlotId": "32321"}`, | |||
| `{"id": }`, | |||
| `{}`, | |||
| `{"placementId": "11523", "adSlotID": "12345"}`, // Can't include both | |||
gargcreation1992
approved these changes
May 23, 2023
Sonali-More-Xandr
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #2654
Updated Prebid Server naming to use
placementIdto match that on Prebid.js: https://docs.prebid.org/dev-docs/bidders/kargo.htmlThe server-side code is backwards compatible to support both namings.
CC @SSuranie