imds: Change imds/synacormedia adapter hostname to be static #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adapter version to endpoint URL.
| @@ -1,5 +1,5 @@ | |||
| # DEPRECATED: Use imds bidder instead | |||
| endpoint: "http://{{.Host}}.technoratimedia.com/openrtb/bids/{{.Host}}" | |||
| endpoint: "https://pbs.technoratimedia.com/openrtb/bids/{{.AccountID}}?src={{.SourceId}}&adapter=synacormedia" | |||
There was a problem hiding this comment.
domain pbs.technoratimedia.com is not reachable
~ » ping pbs.technoratimedia.com oh0387@15852-p-mac
PING adserver.technoratimedia.com (150.136.26.45): 56 data bytes
Request timeout for icmp_seq 0
Request timeout for icmp_seq 1
Request timeout for icmp_seq 2
^C
--- adserver.technoratimedia.com ping statistics ---
4 packets transmitted, 0 packets received, 100.0% packet loss
There was a problem hiding this comment.
domain
pbs.technoratimedia.comis not reachable~ » ping pbs.technoratimedia.com oh0387@15852-p-mac PING adserver.technoratimedia.com (150.136.26.45): 56 data bytes Request timeout for icmp_seq 0 Request timeout for icmp_seq 1 Request timeout for icmp_seq 2 ^C --- adserver.technoratimedia.com ping statistics --- 4 packets transmitted, 0 packets received, 100.0% packet loss
Our servers do not respond to ICMP ping requests. If you issue an HTTP or HTTPS request, it responds:
% curl -i 'http://pbs.technoratimedia.com/'
HTTP/1.1 404 Not Found
Server: nginx
Date: Mon, 22 May 2023 13:19:23 GMT
Content-Length: 0
Connection: keep-alive
access-control-allow-origin: *
access-control-allow-methods: POST,GET,HEAD,OPTIONS
X-Varnish: 47900326
Age: 0
Via: 1.1 varnish
There was a problem hiding this comment.
Thanks @ecammit for clarification
onkarvhanumante
approved these changes
May 23, 2023
gargcreation1992
approved these changes
May 29, 2023
blueseasx
pushed a commit
to blueseasx/prebid-server
that referenced
this pull request
Jun 2, 2023
…adapter version to endpoint URL. (prebid#2793) Co-authored-by: Timothy M. Ace <tace@imds.tv>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imds: Changes the imds/synacormedia adapter hostname to be static (see: #2612) for connection efficiency. Also adds adapter names and version metrics in the request so we can evaluate when to remove the deprecated
synacormediaadapter based upon usage. Endpoint also utilized https now so HTTP/2 may be negotiated.