remove groupm bidder #2798
Merged
remove groupm bidder #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
pm-nilesh-chate
force-pushed
the
remove-groupm-1
branch
from
ad29ef8 to
805791f
Compare
|
Can you please also reomve groupm dev-docs |
|
| @@ -2725,7 +2725,7 @@ func TestExtraBidWithBidAdjustments(t *testing.T) { | |||
| } | |||
| bidAdjustments := map[string]float64{ | |||
| string(openrtb_ext.BidderPubmatic): 2, | |||
| string(openrtb_ext.BidderGroupm): 3, | |||
| "groupm": 3, | |||
There was a problem hiding this comment.
Is there any reason why these references can't be removed completely?
There was a problem hiding this comment.
The purpose of these unit tests is to verify the functionality of the alternatebiddercodes feature, which enables an adapter to provide multiple biddercodes in its response. So, it is more logical to utilise "GroupM" as the alternatebiddercode for pubmatic's request, instead of selecting a random value or bidder.
|
Please update |
Sonali-More-Xandr
approved these changes
May 29, 2023
gargcreation1992
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PBS now has Marketplace support, there is no need for us to continue maintaining the GroupM bidder as the PubMatic Alias in PBS. Therefore, we are removing the bidder. This has already been taken care of in PBJS.
This resolves GroupM's issue at #2654