Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New adapter: Appstock #3054

Merged
merged 4 commits into from
Sep 8, 2023
Merged

New adapter: Appstock #3054

merged 4 commits into from
Sep 8, 2023

Conversation

imedvedko
Copy link
Contributor

gargcreation1992
gargcreation1992 reviewed Aug 28, 2023
View reviewed changes
static/bidder-info/appstock.yaml
@@ -0,0 +1,16 @@
endpoint: "http://ads-pbs.pre.vr-tb.com/openrtb/{{.PublisherID}}?host={{.Host}}"
maintainer:
email: "engineering@project-limelight.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verification sent to this email address. Please reply with confirmed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

received

onkarvhanumante
onkarvhanumante reviewed Aug 28, 2023
View reviewed changes
static/bidder-info/appstock.yaml
@@ -0,0 +1,16 @@
endpoint: "http://ads-pbs.pre.vr-tb.com/openrtb/{{.PublisherID}}?host={{.Host}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified endpoint is reachable

onkarvhanumante
onkarvhanumante previously approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@onkarvhanumante onkarvhanumante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go after @gargcreation1992 approval

@bretg
Copy link
Contributor

bretg commented Aug 30, 2023

docs PR prebid/prebid.github.io#4822

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, cc4e8f1

appstock

Refer here for heat map coverage report

total:	(statements)	0.0%

onkarvhanumante
onkarvhanumante previously approved these changes Sep 7, 2023
View reviewed changes
@imedvedko
Revert "Remove host param"
61eabd4 
This reverts commit cc4e8f1.
@gargcreation1992
Copy link
Contributor

@imedvedko Do you also wanna revert 76fabc4 params test?

@imedvedko
Copy link
Contributor Author

@gargcreation1992 test which I removed in 76fabc4 commit was added in cc4e8f1 but I reverted cc4e8f1 so I don't need to revert 76fabc4

@gargcreation1992
Copy link
Contributor

61eabd4

Don't think you have completely reverted the changes in 61eabd4 commit. Test cases are still missing. Could you please re-check?
Also changes from all the commits do not show the test cases. https://github.com/prebid/prebid-server/pull/3054/files

@imedvedko
Copy link
Contributor Author

@gargcreation1992 This pull request only adds alias, nothing more. Logic is covered by tests, parameters are checked in the limelightDigital adapter. Should it have tests for alias params? I have not met such a requirement before

@gargcreation1992
Copy link
Contributor

@gargcreation1992 This pull request only adds alias, nothing more. Logic is covered by tests, parameters are checked in the limelightDigital adapter. Should it have tests for alias params? I have not met such a requirement before

agreed. I was insisting since you have already added the test cases for bidder params. Since that is covered by the limelightDigital adapter, you do not need to add it for an alias. Approving the PR now.

@onkarvhanumante onkarvhanumante merged commit 01bd679 into prebid:master Sep 8, 2023
3 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Sep 8, 2023
Closed
@imedvedko imedvedko deleted the adapter/appstock branch September 8, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onkarvhanumante onkarvhanumante onkarvhanumante approved these changes

@gargcreation1992 gargcreation1992 gargcreation1992 approved these changes

Assignees

@gargcreation1992 gargcreation1992

@onkarvhanumante onkarvhanumante

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imedvedko @bretg @gargcreation1992 @onkarvhanumante