Taboola Bidder Adapter: Change Endpoint #3058
Conversation
ahmadlob
changed the title
| @@ -1,4 +1,4 @@ | |||
| endpoint: "https://{{.MediaType}}.bidder.taboola.com/OpenRTB/PS/auction/{{.GvlID}}/{{.PublisherID}}" | |||
| endpoint: "https://{{.MediaType}}.bidder.taboola.com/OpenRTB/PS/auction?exchange={{.GvlID}}&publisher={{.PublisherID}}" | |||
There was a problem hiding this comment.
Based on your description in the PR that this addresses the issue #2612, this endpoint is still using the dynamic host. You would need to use the static domain. For example, in this case, MediaType macro needs to be moved out as query param.
There was a problem hiding this comment.
@gargcreation1992 It's not a path param, we currently have two endpoints for two different services that each serve a different media type ( native, display).
There was a problem hiding this comment.
There was a problem hiding this comment.
@ahmadlob Ping to please take a look at Ashish's comment above.
There was a problem hiding this comment.
@gargcreation1992 changed the PR description and title
ahmadlob
changed the title
There was a problem hiding this comment.
Thank you for changing the description. Approving it now!
Please be mindful that this issue does not address #2612
changes in the server endpoint, using query params for publisher id and exchange params instead of path params