Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support case insensitive bidder name in eidpermissions #3141

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

onkarvhanumante
Copy link
Contributor

@onkarvhanumante onkarvhanumante commented Sep 25, 2023

PR makes changes to support case insensitive bidder names in ext.prebid.data.eidpermissions.bidders.

As shown below bidder name appnexus is known name to PBS. But APPNEXUS is unknown. Prior to PR changes PBS would have error out with unknown APPNEXUS bidder name messgae. PR has implemented insensitive bidder name comparison in ext.prebid.data.eidpermissions.bidders

        "ext": {
            "prebid": {
                "data": {
                    "eidpermissions": [
                        {
                            "source": "source1",
                            "bidders": [
                                "APPNEXUS" //  sensitive bidder name
                            ]
                        }
                    ]
                }
          }

partially resolves #2400

@onkarvhanumante onkarvhanumante changed the title Support case insensitive bidder name in ext.prebid.data.eidpermissions.bidders Support case insensitive bidder name in eidpermissions Sep 25, 2023
@gargcreation1992 gargcreation1992 merged commit 27498c8 into master Sep 26, 2023
@gargcreation1992 gargcreation1992 deleted the insensitive-bidder-name-eidspermission branch September 26, 2023 06:07
@bsardo bsardo removed the PBS 2.0 label Sep 26, 2023
@AlexBVolcy
Copy link
Contributor

AlexBVolcy commented Oct 2, 2023

I was testing this to make sure that the case style of the bidder name prior it being down cased, is the style we see in the response. Everything looks good except for one place, within seatbid[0].bid[0].ext.bidder, this field was still down cased. Just want to flag, to see if this is an issue.

    "seatbid": [
        {
            "bid": [
                {
                    "id": "7242495867728566188",
                    "impid": "some-impression-id",
                    "price": 0.01,
                    "adm": "<script src=\"https://lax1-ib.adnxs.com/ab?an_audit=0&test=1&e=wqT_3QKhDOAhBgAAAwDWAAUBCMvV7KgGELiS7byhg4n0QhjM1rDYsraZ0lAqNgl7FK5H4XqEPxF7FK5H4XqEPxkREgAhEQkAKREJADERCagw-6uSBjjMG0DMG0gCUNCEvzNYsataYABoo79NeOziBYABAYoBA1VTRJIBAQb0UwGYAdgEoAH0A6gBAbABALgBAsABA8gBAtABCdgBAOABAfABAIoCKXVmKCdhJywgODAyNTk0LCAwKTt1ZigncicsIDEwNzk4NzUzNiwgMCk7kgKhBCFWbUlvM1FpTTA5c1VFTkNFdnpNWUFDQ3hxMW93QURnQVFBUkl6QnRRLTZ1U0JsZ0FZUFFFYUFCd0FIZ0FnQUVBaUFFQWtBRUJtQUVCb0FFQnFBRURzQUVBdVFHUjd3cnc0WHFFUDhFQmtlOEs4T0Y2aERfSkFacWkyZlZkRHdGQTJRRUFBQUFBQUFEd1AtQUJBUFVCQUFBQUFKZ0NBS0FDQUxVQ0FBQUFBTDBDQUFBQUFNQUNBTWdDQU5BQ0FOZ0NBT0FDQU9nQ0FQZ0NBSUFEQVpnREFib0RDVXhCV0RFNk5qWXhNZUFEMFVTSUJBQ1FCQUNZQkFIQkJBQUFBQUFBAXwIeVFRAQcJARhOZ0VBUEVFCQ0BASBDSUJkTXpxUVUBDSBBQUFEd1A3RUYBCgkBCERCQh0_AHkVKAxBQUFOMigAAFouKADwdTRBWG9CLW9GSmdnREVpSUFBQVBPQlh3VGpvdlBaTmlhV2hjeWFwZnNyR0RSU2tmWklGYmk0RzlBTFJCWThBVzFodnNDLUFXaV9qQ0NCZ05WVTBTSUJnQ1FCZ0dZQmdDaEJuc1Vya2ZoZW9RX3FBWUJzZ1lrQ1EBlQkBAEUdtABHHQwASR0MNHVBWWWaApUBIXJ4SnlvOiUCoHNhdGFJQVFvQURGN0ZLNUg0WHFFUHpvSlRFRllNVG8yTmpFeFFORkVTEVEMUEFfVREMDEFBQVcdDABZHQwAYR0MAGMdDBBlQUNKQR0QVNgCAOAC6Kgr8gIQCgZBRFZfSUQSBjhF9BzyAhEKBkNQRwETOAc2MjEwMzU38gIRCgVDUAETNAg0MzQ0NDYyMPICDQoIATsURlJFURIBCRAcUkVNX1VTRVIFEAAnCSCgQ09ERRIbTWFuYWdlZF9CdXllcl81NmE3Y2MwMWUxNGQy8gIMCghDUEcJKhwA8gILCgdDUBUOEAkKBUlPAXsJGgRJTxUaOBMKD0NVU1RPTV9NT0RFTA0kCBoKFjIWACBMRUFGX05BTUUBQQgeCho2HQAIQVNUAT4QSUZJRUQBIRwNCghTUExJVAFN8OUBMIADAIgDAZADAJgDFKADAaoDAMAD2ATIAwDYAwDgAwDoAwD4AwCABACSBAkvb3BlbnJ0YjKYBACoBMTfB7IEDAgAEAAYACAAMAA4ALgEAMAEAMgEANIEDjM1MzIjTEFYMTo2NjEx2gQCCAHgBADwBNCEvzP6BBIJAAAAwDU_JEARAAAA4JofNECIBQGYBQCgBf___________wGqBQ9zb21lLXJlcXVlc3QtaWTABQDJBQAAAAAAAPA_0gUJCQAAAAAAAAAA2AUB4AUB8AUB-gUECAAQAJAGAJgGALgGAMEGAAAAAAEvINAG2w3aBhYKEAEwLgEAdBAAGADgBgHyBgIIAIAHAYgHAKAHAcgH7OIF0gcNCREqASYI2gcGCe-w4AcA6gcCCADwBwCKCAIQAJUIAACAP5gIAcAIANIIDgiBgoSIkKDAgAEQARgA&s=905ff0668af5f22b39abdb91789a4026a40ea5b3&pp=${AUCTION_PRICE}\"></script>",
                    "adid": "107987536",
                    "adomain": [
                        "example.com"
                    ],
                    "iurl": "https://lax1-ib.adnxs.com/cr?id=107987536",
                    "cid": "3532",
                    "crid": "107987536",
                    "w": 600,
                    "h": 500,
                    "ext": {
                        "appnexus": { **// HERE IS THE DOWN CASED BIDDER**
                            "auction_id": 4821143095583918000,
                            "bid_ad_type": 0,
                            "bidder_id": 2,
                            "brand_id": 1
                        },
                        "origbidcpm": 0.01,
                        "origbidcur": "USD",
                        "prebid": {
                            "events": {
                                "win": "http://localhost:8000/event?t=win&b=7242495867728566188&a=unknown&bidder=APPNEXUS&ts=1696279243289",
                                "imp": "http://localhost:8000/event?t=imp&b=7242495867728566188&a=unknown&bidder=APPNEXUS&ts=1696279243289"
                            },
                            "meta": {
                                "adaptercode": "APPNEXUS"
                            },
                            "targeting": {
                                "hb_bidder": "APPNEXUS",
                                "hb_env": "mobile-app",
                                "hb_pb": "0.00",
                                "hb_size": "600x500"
                            },
                            "type": "banner",
                            "video": {
                                "duration": 0,
                                "primary_category": ""
                            }
                        }
                    }
                }
            ],
            "seat": "APPNEXUS"
        }
    ],

@onkarvhanumante
Copy link
Contributor Author

I was testing this to make sure that the case style of the bidder name prior it being down cased, is the style we see in the response. Everything looks good except for one place, within seatbid[0].bid[0].ext.bidder, this field was still down cased. Just want to flag, to see if this is an issue.

    "seatbid": [
        {
            "bid": [
                {
                    "id": "7242495867728566188",
                    "impid": "some-impression-id",
                    "price": 0.01,
                    "adm": "<script src=\"https://lax1-ib.adnxs.com/ab?an_audit=0&test=1&e=wqT_3QKhDOAhBgAAAwDWAAUBCMvV7KgGELiS7byhg4n0QhjM1rDYsraZ0lAqNgl7FK5H4XqEPxF7FK5H4XqEPxkREgAhEQkAKREJADERCagw-6uSBjjMG0DMG0gCUNCEvzNYsataYABoo79NeOziBYABAYoBA1VTRJIBAQb0UwGYAdgEoAH0A6gBAbABALgBAsABA8gBAtABCdgBAOABAfABAIoCKXVmKCdhJywgODAyNTk0LCAwKTt1ZigncicsIDEwNzk4NzUzNiwgMCk7kgKhBCFWbUlvM1FpTTA5c1VFTkNFdnpNWUFDQ3hxMW93QURnQVFBUkl6QnRRLTZ1U0JsZ0FZUFFFYUFCd0FIZ0FnQUVBaUFFQWtBRUJtQUVCb0FFQnFBRURzQUVBdVFHUjd3cnc0WHFFUDhFQmtlOEs4T0Y2aERfSkFacWkyZlZkRHdGQTJRRUFBQUFBQUFEd1AtQUJBUFVCQUFBQUFKZ0NBS0FDQUxVQ0FBQUFBTDBDQUFBQUFNQUNBTWdDQU5BQ0FOZ0NBT0FDQU9nQ0FQZ0NBSUFEQVpnREFib0RDVXhCV0RFNk5qWXhNZUFEMFVTSUJBQ1FCQUNZQkFIQkJBQUFBQUFBAXwIeVFRAQcJARhOZ0VBUEVFCQ0BASBDSUJkTXpxUVUBDSBBQUFEd1A3RUYBCgkBCERCQh0_AHkVKAxBQUFOMigAAFouKADwdTRBWG9CLW9GSmdnREVpSUFBQVBPQlh3VGpvdlBaTmlhV2hjeWFwZnNyR0RSU2tmWklGYmk0RzlBTFJCWThBVzFodnNDLUFXaV9qQ0NCZ05WVTBTSUJnQ1FCZ0dZQmdDaEJuc1Vya2ZoZW9RX3FBWUJzZ1lrQ1EBlQkBAEUdtABHHQwASR0MNHVBWWWaApUBIXJ4SnlvOiUCoHNhdGFJQVFvQURGN0ZLNUg0WHFFUHpvSlRFRllNVG8yTmpFeFFORkVTEVEMUEFfVREMDEFBQVcdDABZHQwAYR0MAGMdDBBlQUNKQR0QVNgCAOAC6Kgr8gIQCgZBRFZfSUQSBjhF9BzyAhEKBkNQRwETOAc2MjEwMzU38gIRCgVDUAETNAg0MzQ0NDYyMPICDQoIATsURlJFURIBCRAcUkVNX1VTRVIFEAAnCSCgQ09ERRIbTWFuYWdlZF9CdXllcl81NmE3Y2MwMWUxNGQy8gIMCghDUEcJKhwA8gILCgdDUBUOEAkKBUlPAXsJGgRJTxUaOBMKD0NVU1RPTV9NT0RFTA0kCBoKFjIWACBMRUFGX05BTUUBQQgeCho2HQAIQVNUAT4QSUZJRUQBIRwNCghTUExJVAFN8OUBMIADAIgDAZADAJgDFKADAaoDAMAD2ATIAwDYAwDgAwDoAwD4AwCABACSBAkvb3BlbnJ0YjKYBACoBMTfB7IEDAgAEAAYACAAMAA4ALgEAMAEAMgEANIEDjM1MzIjTEFYMTo2NjEx2gQCCAHgBADwBNCEvzP6BBIJAAAAwDU_JEARAAAA4JofNECIBQGYBQCgBf___________wGqBQ9zb21lLXJlcXVlc3QtaWTABQDJBQAAAAAAAPA_0gUJCQAAAAAAAAAA2AUB4AUB8AUB-gUECAAQAJAGAJgGALgGAMEGAAAAAAEvINAG2w3aBhYKEAEwLgEAdBAAGADgBgHyBgIIAIAHAYgHAKAHAcgH7OIF0gcNCREqASYI2gcGCe-w4AcA6gcCCADwBwCKCAIQAJUIAACAP5gIAcAIANIIDgiBgoSIkKDAgAEQARgA&s=905ff0668af5f22b39abdb91789a4026a40ea5b3&pp=${AUCTION_PRICE}\"></script>",
                    "adid": "107987536",
                    "adomain": [
                        "example.com"
                    ],
                    "iurl": "https://lax1-ib.adnxs.com/cr?id=107987536",
                    "cid": "3532",
                    "crid": "107987536",
                    "w": 600,
                    "h": 500,
                    "ext": {
                        "appnexus": { **// HERE IS THE DOWN CASED BIDDER**
                            "auction_id": 4821143095583918000,
                            "bid_ad_type": 0,
                            "bidder_id": 2,
                            "brand_id": 1
                        },
                        "origbidcpm": 0.01,
                        "origbidcur": "USD",
                        "prebid": {
                            "events": {
                                "win": "http://localhost:8000/event?t=win&b=7242495867728566188&a=unknown&bidder=APPNEXUS&ts=1696279243289",
                                "imp": "http://localhost:8000/event?t=imp&b=7242495867728566188&a=unknown&bidder=APPNEXUS&ts=1696279243289"
                            },
                            "meta": {
                                "adaptercode": "APPNEXUS"
                            },
                            "targeting": {
                                "hb_bidder": "APPNEXUS",
                                "hb_env": "mobile-app",
                                "hb_pb": "0.00",
                                "hb_size": "600x500"
                            },
                            "type": "banner",
                            "video": {
                                "duration": 0,
                                "primary_category": ""
                            }
                        }
                    }
                }
            ],
            "seat": "APPNEXUS"
        }
    ],

@AlexBVolcy could you share auction request used for testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bidder names should be case insensitive
5 participants