Allow bidders to skip sync for GDPR/GPP #3265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhhjort
reviewed
Oct 31, 2023
usersync/chooser.go
Outdated
| @@ -177,9 +184,17 @@ func (c standardChooser) evaluate(bidder string, syncersSeen map[string]struct{} | |||
| return nil, BidderEvaluation{Status: StatusBlockedByGDPR, Bidder: bidder, SyncerKey: syncer.Key()} | |||
| } | |||
|
|
|||
| if c.bidderInfo[bidder].Syncer != nil && c.bidderInfo[bidder].Syncer.SkipWhen != nil && c.bidderInfo[bidder].Syncer.SkipWhen.GDPR { | |||
There was a problem hiding this comment.
Shouldn't there be a check here to see if the GDPR applies? Otherwise we will always skip every request when they ask to skip when the GDPR applies. May want to put this in front of the GDPR check above so we don't bother checking if they pass the GDPR if they want to skip any GDPR requests.
hhhjort
reviewed
Oct 31, 2023
usersync/chooser.go
Outdated
| if !privacy.CCPAAllowsBidderSync(bidderNormalized.String()) { | ||
| return nil, BidderEvaluation{Status: StatusBlockedByCCPA, Bidder: bidder, SyncerKey: syncer.Key()} | ||
| } | ||
|
|
||
| if c.bidderInfo[bidder].Syncer != nil && c.bidderInfo[bidder].Syncer.SkipWhen != nil && c.bidderInfo[bidder].Syncer.SkipWhen.GPPSID == GPPSID { |
There was a problem hiding this comment.
According to the linked issue, the configured GPPSID is a list of GPPSIDs that they want to skip on. So you need to transform the string from the config into a list of IDs, and then check if the incoming GPPSID matches any one of them.
endpoints/cookie_sync.go
Outdated
Comment on lines
539
to
544
| func (p usersyncPrivacy) GDPRInScope() bool { | ||
| if p.gdprSignal == gdpr.SignalYes { | ||
| return true | ||
| } | ||
| return false | ||
| } |
There was a problem hiding this comment.
Super nitpick.
This func can be rewritten to
func (p usersyncPrivacy) GDPRInScope() bool {
return p.gdprSignal == gdpr.SignalYes
}
VeronikaSolovei9
previously approved these changes
Nov 2, 2023
AlexBVolcy
dismissed stale reviews from VeronikaSolovei9 and hhhjort
via
e43e3ea
hhhjort
approved these changes
Nov 20, 2023
VeronikaSolovei9
approved these changes
Nov 24, 2023
bsardo
changed the title
SuprPhatAnon
pushed a commit
to GiftConnect/prebid-server
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses this issue: #3102
This PR was re-uploaded because of issues I was facing with merge conflicts