Criteo: Add support for native #3709
Conversation
MarinaZhuravlevaCriteo
commented
May 29, 2024
MarinaZhuravlevaCriteo
commented
- Added native media type in list of capabilities for criteo.yaml
- Added test for simple native case for criteo adapter
bsardo
changed the title
|
Hello, Please could you review this ? Thanks! |
|
Hello team Small up on this PR that has been opened for a while now 🙏 Many thanks |
| }, | ||
| "ext": { | ||
| "bidder": { | ||
| "uid": 1 |
There was a problem hiding this comment.
Nitpick: it doesn't effect the test behavior but uid doesn't appear to be a valid bidder parameter for your bidder. It might be best to specify a real bidder param here like zoneid.
There was a problem hiding this comment.
I just updated the chance, using uid here was not the intent
leonardlabat
force-pushed
the
support-native
branch
from
6a6a5ee to
08b59d1
Compare
There was a problem hiding this comment.
For future reference, once the review cycle has started, please avoid force pushing and instead push up new commits (or merge with master if you need to resolve merge conflicts) as it makes it much easier for reviewers as we just need to review the delta instead of re-reviewing the entire PR.
All of the commits are squashed when we merge.
Thanks!
