Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Expect Array Overwrites in Imp FPD Tests #3725

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

bsardo
Copy link
Collaborator

@bsardo bsardo commented Jun 4, 2024

A recent change to the util/jsonutil#merge.go function fixed a problem where arrays were being merged instead of overwritten. Recently added Imp FPD tests were expecting merges instead of overwrites and needed to be updated as such.

Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo merged commit ecf3171 into prebid:master Jun 4, 2024
3 checks passed
mefjush pushed a commit to adhese/prebid-server that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants