LemmaDigital: add host parameter #3750

lm-ved · 2024-06-13T10:46:17Z

update bid adapter

📋 Checklist

Related pull requests in prebid.github.io are linked : [LemmaDigital] PBS parameter update prebid.github.io#5418

github-actions · 2024-06-13T10:47:07Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, b583eb4

lemmadigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:23:	Builder			80.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:35:	MakeRequests		87.5%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:74:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:110:	buildEndpointURL	100.0%
total:										(statements)		92.7%

SyntaxNode · 2024-06-25T22:58:54Z

static/bidder-params/lemmadigital.json

+        "host": {
+            "type": "string",
+            "description": "Network Host to request from",
+            "enum": ["uses", "usws", "usct", "emea", "sg", "doohsg", "doohus"]


In the case of region specific routing, we recommend the solution of documenting the different endpoints supported by your adapter and hosts can configure their data centers to match. PBS already allows endpoints to be configured via application settings (environment variable or pbs.yaml).

We prefer not asking publishers to enter the region in each one of their placement configs. This is really a server level configuration.

@bsardo @bretg

Good catch @SyntaxNode . @lm-ved , please see https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html#consider-your-geography and the example . Basically, pubs can't reasonably determine the geography.

# We have the following regional endpoint domains: "uses" (us-east), "usws" (us-west), "usct" (us-central), "emea" (europe middle east africa), "sg" (where's this?) # Please deploy this config in each of your datacenters with the appropriate regional subdomain endpoint: "http://REGION.example.com/openrtb2" geoscope: - USA - CAN

As for separate endpoints for DOOH vs display, I think that's a problem. @SyntaxNode - can we allow them to create a bidder-specific "regioncode" YAML entry that's filled in by the host company and is available to their runtime code? If so, then the adapter can look at regioncode along with site/app/dooh and determine the endpoint.

@SyntaxNode / @bretg ,
Would I be correct in assuming the following change would suffice in this adapter's case?

# We have the following regional endpoint domains: "uses" (us-east), "usws" (us-west), "usct" (us-central), "emea" (europe middle east africa), "sg" (singapore) # Please deploy this config in each of your datacenters with the appropriate regional subdomain endpoint: "https://REGION.ads.lemmatechnologies.com/lemma/servad?src=prebid&pid={{.PublisherID}}&aid={{.AdUnit}}" geoscope: - global

instead of the current:

endpoint: "https://{{.Host}}.ads.lemmatechnologies.com/lemma/servad?src=prebid&pid={{.PublisherID}}&aid={{.AdUnit}}"

It also would depend on the decision regarding how to handle the different endpoints for DOOH.

@SyntaxNode - can we allow them to create a bidder-specific "regioncode" YAML entry that's filled in by the host company and is available to their runtime code?

Yup. This is a good use for the extra_info field. Hosts can override this value in the appropriate data centers just as they would the endpoint. For details, please visit https://docs.prebid.org/prebid-server/developers/add-new-bidder-go.html and search for "extra_info" and "ExtraAdapterInfo".

Would I be correct in assuming the following change would suffice in this adapter's case?

Yes, but please disable this adapter by default (hosts can enable it) since the endpoint is not valid by default. This is the same approach used by the Rubicon/Magnite adapter.

@SyntaxNode , thank you for the details.
I've added the host option as an extra_info field. I have also kept a default value and removed host from the required array of bidder-params. This would allow for both - a server-level config and a publisher to provide it if needed, with a default(set to the current adapter's host ) in case it is neither.

This would allow for both - a server-level config and a publisher to provide it if needed, with a default(set to the current adapter's host ) in case it is neither.

@bretg Are you good with giving publishers an option to set it per-request?

I suppose. Don't expect anyone to get it right.

github-actions · 2024-06-28T15:55:33Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 84b7018

lemmadigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:55:	Builder			87.5%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:73:	MakeRequests		87.5%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:112:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:148:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:155:	parseExtraInfo		92.3%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:181:	defaultHost		100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:185:	assignDoohHost		100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:196:	resolveHost		83.3%
total:										(statements)		92.9%

adapters/lemmadigital/lemmadigital.go

SyntaxNode · 2024-06-28T20:54:59Z

static/bidder-params/lemmadigital.json

+        "host": {
+            "type": "string",
+            "description": "Network Host to request from",
+            "enum": ["uses", "usws", "usct", "emea", "sg", "doohsg", "doohus"]


This would allow for both - a server-level config and a publisher to provide it if needed, with a default(set to the current adapter's host ) in case it is neither.

@bretg Are you good with giving publishers an option to set it per-request?

github-actions · 2024-06-29T07:02:19Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, a26ae59

lemmadigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:55:	Builder			87.5%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:73:	MakeRequests		87.5%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:112:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:148:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:155:	parseExtraInfo		92.3%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:181:	defaultHost		100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:185:	assignDoohHost		100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:196:	resolveHost		83.3%
total:										(statements)		92.9%

static/bidder-info/lemmadigital.yaml

bretg

My review is for approach only. Did not look at the code.

lm-ved · 2024-07-09T05:18:01Z

Hi @SyntaxNode / @bretg / @bsardo ,
Are there any other changes required before this can be approved/merged?

github-actions · 2024-07-27T16:00:01Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 2e1cb18

lemmadigital

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:55:	Builder			87.5%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:73:	MakeRequests		87.5%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:112:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:148:	buildEndpointURL	100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:155:	parseExtraInfo		92.3%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:181:	defaultHost		100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:185:	assignDoohHost		100.0%
github.com/prebid/prebid-server/v2/adapters/lemmadigital/lemmadigital.go:196:	resolveHost		83.3%
total:										(statements)		92.9%

lm-ved · 2024-07-30T03:03:49Z

Hi @SyntaxNode / @bretg / @bsardo ,
We've also added commit: 2e1cb18 to support usersync. Let us know please if there are any further steps for this to be approved/merged.

bsardo · 2024-07-31T19:33:28Z

@lm-ved, I will give this a look shortly.

lm-pramod-jadhav · 2024-08-13T05:32:37Z

@bsardo Could you please review this? It is a very important and business-impacting change for us. Let us know if there are any outstanding action items for approval.

Thank you.

lm-ved · 2024-08-16T06:36:23Z

Hi @bsardo / @SyntaxNode / @bretg,
I've created another PR that has fewer changes to help expedite the review process: #3862 .
Please review it instead of this one for the time being.
Moving this one to draft until the linked PR is merged.

bsardo · 2024-09-16T15:34:02Z

@lm-ved your other PR has been merged. Let me know when this is ready for review again.

SyntaxNode · 2024-11-05T16:21:33Z

@lm-ved The prerequisite PR has been merged. You are clear to proceed with this one. If you're unable to revisit this PR at this time, we will close it next week due to inactivity. You are welcome to reopen it anytime after when you're ready.

lm-ved · 2024-11-06T14:58:53Z

@SyntaxNode , thanks for informing. I would like to revisit this PR in the near future so I will re-open it later. Closing it out until then.

lm-ved added 2 commits May 21, 2024 10:30

Made host parameter changes

600e609

added dooh object support and tests

b583eb4

lm-ved mentioned this pull request Jun 13, 2024

[LemmaDigital] PBS parameter update prebid/prebid.github.io#5418

Closed

2 tasks

bsardo changed the title ~~[LemmaDigital] host parameter introduced~~ LemmaDigital: add host parameter Jun 13, 2024

SyntaxNode reviewed Jun 26, 2024

View reviewed changes

SyntaxNode self-assigned this Jun 26, 2024

lm-ved added 2 commits June 28, 2024 21:21

extra adapter info - host

5d0cf0e

host can be optionally passed-in as a parameter

84b7018

SyntaxNode reviewed Jun 28, 2024

View reviewed changes

addressed review comments

a26ae59

lm-ved requested review from SyntaxNode and bretg June 29, 2024 07:05

bretg reviewed Jul 2, 2024

View reviewed changes

static/bidder-info/lemmadigital.yaml Show resolved Hide resolved

bretg previously approved these changes Jul 2, 2024

View reviewed changes

userSync config

2e1cb18

lm-ved dismissed bretg’s stale review via 2e1cb18 July 27, 2024 15:59

bsardo self-assigned this Jul 31, 2024

lm-ved mentioned this pull request Aug 16, 2024

LemmaDigital: change endpoint #3862

Merged

2 tasks

lm-ved marked this pull request as draft August 16, 2024 06:49

lm-ved closed this Nov 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LemmaDigital: add host parameter #3750

LemmaDigital: add host parameter #3750

lm-ved commented Jun 13, 2024

github-actions bot commented Jun 13, 2024

SyntaxNode Jun 25, 2024

bretg Jun 26, 2024

lm-ved Jun 27, 2024

SyntaxNode Jun 27, 2024 •

edited

Loading

lm-ved Jun 28, 2024

SyntaxNode Jun 28, 2024

bretg Jun 28, 2024

github-actions bot commented Jun 28, 2024

SyntaxNode Jun 28, 2024

github-actions bot commented Jun 29, 2024

bretg left a comment

lm-ved commented Jul 9, 2024

github-actions bot commented Jul 27, 2024

lm-ved commented Jul 30, 2024

bsardo commented Jul 31, 2024

lm-pramod-jadhav commented Aug 13, 2024

lm-ved commented Aug 16, 2024

bsardo commented Sep 16, 2024

SyntaxNode commented Nov 5, 2024 •

edited

Loading

lm-ved commented Nov 6, 2024

LemmaDigital: add host parameter #3750

LemmaDigital: add host parameter #3750

Conversation

lm-ved commented Jun 13, 2024

📋 Checklist

github-actions bot commented Jun 13, 2024

Code coverage summary

lemmadigital

SyntaxNode Jun 25, 2024

Choose a reason for hiding this comment

bretg Jun 26, 2024

Choose a reason for hiding this comment

lm-ved Jun 27, 2024

Choose a reason for hiding this comment

SyntaxNode Jun 27, 2024 • edited Loading

Choose a reason for hiding this comment

lm-ved Jun 28, 2024

Choose a reason for hiding this comment

SyntaxNode Jun 28, 2024

Choose a reason for hiding this comment

bretg Jun 28, 2024

Choose a reason for hiding this comment

github-actions bot commented Jun 28, 2024

Code coverage summary

lemmadigital

SyntaxNode Jun 28, 2024

Choose a reason for hiding this comment

github-actions bot commented Jun 29, 2024

Code coverage summary

lemmadigital

bretg left a comment

Choose a reason for hiding this comment

lm-ved commented Jul 9, 2024

github-actions bot commented Jul 27, 2024

Code coverage summary

lemmadigital

lm-ved commented Jul 30, 2024

bsardo commented Jul 31, 2024

lm-pramod-jadhav commented Aug 13, 2024

lm-ved commented Aug 16, 2024

bsardo commented Sep 16, 2024

SyntaxNode commented Nov 5, 2024 • edited Loading

lm-ved commented Nov 6, 2024

SyntaxNode Jun 27, 2024 •

edited

Loading

SyntaxNode commented Nov 5, 2024 •

edited

Loading