Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LemmaDigital: change endpoint #3862

Merged
merged 3 commits into from
Sep 16, 2024
Merged

LemmaDigital: change endpoint #3862

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08e770e
switched endpoint and added userSync config
lm-ved Aug 12, 2024
b00e873
updated usersync config
lm-ved Aug 22, 2024
637b084
updated test url to avoid future changes in multiple files
lm-ved Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion adapters/lemmadigital/lemmadigital_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (

func TestJsonSamples(t *testing.T) {
bidder, buildErr := Builder(openrtb_ext.BidderLemmadigital, config.Adapter{
Endpoint: "https://sg.ads.lemmatechnologies.com/lemma/servad?pid={{.PublisherID}}&aid={{.AdUnit}}"}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})
Endpoint: "https://pbid.lemmamedia.com/lemma/servad?src=prebid&pid={{.PublisherID}}&aid={{.AdUnit}}"}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using a fake url for your tests so that you don't have to make all of these changes to the test files if you need to change your endpoint.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsardo , updated the tests with a fake url to avoid future test url changes.


if buildErr != nil {
t.Fatalf("Builder returned unexpected error %v", buildErr)
Expand Down
2 changes: 1 addition & 1 deletion adapters/lemmadigital/lemmadigitaltest/exemplary/banner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@

"httpCalls": [{
"expectedRequest": {
"uri": "https://sg.ads.lemmatechnologies.com/lemma/servad?pid=1&aid=1",
"uri": "https://pbid.lemmamedia.com/lemma/servad?src=prebid&pid=1&aid=1",
"body": {
"id": "test-request-id",
"imp": [{
Expand Down
2 changes: 1 addition & 1 deletion adapters/lemmadigital/lemmadigitaltest/exemplary/multi-imp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@

"httpCalls": [{
"expectedRequest": {
"uri": "https://sg.ads.lemmatechnologies.com/lemma/servad?pid=1&aid=1",
"uri": "https://pbid.lemmamedia.com/lemma/servad?src=prebid&pid=1&aid=1",
"body": {
"id": "test-request-id",
"imp": [{
Expand Down
2 changes: 1 addition & 1 deletion adapters/lemmadigital/lemmadigitaltest/exemplary/video.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

"httpCalls": [{
"expectedRequest": {
"uri": "https://sg.ads.lemmatechnologies.com/lemma/servad?pid=1&aid=1",
"uri": "https://pbid.lemmamedia.com/lemma/servad?src=prebid&pid=1&aid=1",
"body": {
"id": "test-request-id-video",
"imp": [{
Expand Down
2 changes: 1 addition & 1 deletion adapters/lemmadigital/lemmadigitaltest/supplemental/empty-seatbid-array.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
},
"httpCalls": [{
"expectedRequest": {
"uri": "https://sg.ads.lemmatechnologies.com/lemma/servad?pid=1&aid=1",
"uri": "https://pbid.lemmamedia.com/lemma/servad?src=prebid&pid=1&aid=1",
"body": {
"app": {
"bundle": "com.ld.test",
Expand Down
2 changes: 1 addition & 1 deletion adapters/lemmadigital/lemmadigitaltest/supplemental/invalid-response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

"httpCalls": [{
"expectedRequest": {
"uri": "https://sg.ads.lemmatechnologies.com/lemma/servad?pid=1&aid=1",
"uri": "https://pbid.lemmamedia.com/lemma/servad?src=prebid&pid=1&aid=1",
"body": {
"id": "test-request-id-video",
"imp": [{
Expand Down
2 changes: 1 addition & 1 deletion adapters/lemmadigital/lemmadigitaltest/supplemental/status-code-bad-request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

"httpCalls": [{
"expectedRequest": {
"uri": "https://sg.ads.lemmatechnologies.com/lemma/servad?pid=1&aid=1",
"uri": "https://pbid.lemmamedia.com/lemma/servad?src=prebid&pid=1&aid=1",
"body": {
"id": "test-request-id-video",
"imp": [{
Expand Down
2 changes: 1 addition & 1 deletion adapters/lemmadigital/lemmadigitaltest/supplemental/status-code-no-content.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

"httpCalls": [{
"expectedRequest": {
"uri": "https://sg.ads.lemmatechnologies.com/lemma/servad?pid=1&aid=1",
"uri": "https://pbid.lemmamedia.com/lemma/servad?src=prebid&pid=1&aid=1",
"body": {
"id": "test-request-id-video",
"imp": [{
Expand Down
2 changes: 1 addition & 1 deletion adapters/lemmadigital/lemmadigitaltest/supplemental/status-code-other-error.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

"httpCalls": [{
"expectedRequest": {
"uri": "https://sg.ads.lemmatechnologies.com/lemma/servad?pid=1&aid=1",
"uri": "https://pbid.lemmamedia.com/lemma/servad?src=prebid&pid=1&aid=1",
"body": {
"id": "test-request-id-video",
"imp": [{
Expand Down
8 changes: 6 additions & 2 deletions static/bidder-info/lemmadigital.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
endpoint: "https://sg.ads.lemmatechnologies.com/lemma/servad?pid={{.PublisherID}}&aid={{.AdUnit}}"
endpoint: "https://pbid.lemmamedia.com/lemma/servad?src=prebid&pid={{.PublisherID}}&aid={{.AdUnit}}"
maintainer:
lm-ved marked this conversation as resolved.
Show resolved Hide resolved
email: support@lemmatechnologies.com
endpointCompression: gzip
Expand All @@ -11,4 +11,8 @@ capabilities:
site:
mediaTypes:
- banner
- video
- video
userSync:
iframe:
url: "https://sync.lemmadigital.com/js/usersync.html?redirect={{.RedirectURL}}"
userMacro: "${UUID}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-08-19 at 3 28 45 PM

Usersync url is not working.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an URL that I tried - https://sync.lemmadigital.com/js/usersync.html?redirect=https%3A%2F%2Fib.adnxs.com%2Fprebid%2Fsetuid%3Fbidder%3Dlemmadigital%26gdpr%3D%26gdpr_consent%3D%26gpp%3D%26gpp_sid%3D%26f%3Db%26uid%3D%24%7BUUID%7D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imedvedko Requesting you to please fix this usersync URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imedvedko Requesting you to please fix this usersync URL.

It's not me 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gargcreation1992 , please check now, we've made an update to the url.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UID is still not being set. Getting the following redirect URL -

https://ib.adnxs.com/prebid/setuid?bidder=lemmadigital&gdpr=&gdpr_consent=&gpp=&gpp_sid=&f=b&uid=${UUID}&

Copy link
Contributor Author

@lm-ved lm-ved Aug 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gargcreation1992, can you share which URL you used to check this?

It worked for me:
image

URL used:

https://sync.lemmadigital.com/setuid?publisher=850&redirect=https%3A%2F%2Fib.adnxs.com%2Fprebid%2Fsetuid%3Fbidder%3Dlemmadigital%26gdpr%3D%26gdpr_consent%3D%26gpp%3D%26gpp_sid%3D%26f%3Db%26uid%3D%24%7BUUID%7D

Note: The recent commit: b00e873 prior to this comment: #3862 (comment) had changed the URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gargcreation1992 , did you get a chance to check this comment: #3862 (comment)?
Share the details please if there is additional feedback.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user sync verified using https://sync.lemmadigital.com/setuid?publisher=850&redirect=http%3A%2F%2Flocalhost%3A8000%2Fsetuid%3Fbidder%3Dlemmadigital%26gdpr%3D%26gdpr_consent%3D%26gpp%3D%26gpp_sid%3D%26f%3Db%26uid%3D%24%7BUUID%7D

Screenshot 2024-09-13 at 3 22 41 PM

cookie after sync completes:

echo "eyJ0ZW1wVUlEcyI6eyJsZW1tYWRpZ2l0YWwiOnsidWlkIjoiNDUxODEwOWMtNzIwMC0xMWVmLWFjNWUtZDA4ZTc5ZjZjZjdlIiwiZXhwaXJlcyI6IjIwMjQtMDktMjdUMTU6MjA6NDAuNDkzNDYxLTA0OjAwIn19fQ" | base64 -D
{"tempUIDs":{"lemmadigital":{"uid":"4518109c-7200-11ef-ac5e-d08e79f6cf7e","expires":"2024-09-27T15:20:40.493461-04:00"}}

Loading