-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rubicon: Pass PBS host info to XAPI #3903
Conversation
d7201c1
to
06f32e8
Compare
Code coverage summaryNote:
rubiconRefer here for heat map coverage report
|
if err != nil { | ||
t.Fatal("Error extracting pbs_version") | ||
} | ||
assert.Equal(t, pbsVersion, "", "Unexpected pbs_version value") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any ideas on how to actually test version?
In pbs Java we just mock it. But it seems like here nobody tests it.
I can set version.Ver
to test value at the beginning of test and defer its reset, but it is a dirty hack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure there is any value in adding any additional test logic here, nor do I see an easy way to fake it. The version is just a string and is populated during the build process. Checking that it is empty seems sufficient to me since it will predictably always be an empty string in your unit tests.
We already have test coverage for the version package including the Ver
field in endpoints/version_test.go
so we can feel confident that Ver
is set correctly on startup assuming the build is triggered with the version as a parameter.
Changes from prebid/prebid-server-java#3377