Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubicon: Update video size-id logic #3917

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

CTMBNara
Copy link
Contributor

No description provided.

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 7fc3091

rubicon

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:172:	appendTrackerToUrl			87.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:188:	Builder					100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:199:	updateRequestTo26			92.3%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:224:	MakeRequests				80.6%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:536:	createImpsToExtMap			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:555:	prepareImpsToExtMap			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:574:	splitMultiFormatImp			61.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:611:	resolveBidFloor				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:619:	updateImpRpTargetWithFpdAttributes	81.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:719:	extractDfpAdUnitCode			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:729:	isNotKeyPathError			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:733:	addStringAttribute			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:737:	addStringArrayAttribute			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:741:	updateUserRpTargetWithFpdAttributes	70.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:771:	updateExtWithIabAttribute		100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:780:	populateFirstPartyDataAttributes	92.9%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:808:	isStringArray				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:818:	isBoolArray				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:828:	convertToStringArray			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:839:	rawJSONToMap				100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:847:	mapFromRawJSON				80.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:856:	getSegmentIdsToCopy			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:876:	contains				75.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:885:	isVideo					100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:894:	isFullyPopulatedVideo			100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:899:	resolveNativeObject			88.2%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:931:	setImpNative				82.4%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:960:	MakeBids				92.2%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1060:	mapImpIdToCpmOverride			90.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1078:	resolveAdm				87.5%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1093:	cmpOverrideFromBidRequest		100.0%
github.com/prebid/prebid-server/v2/adapters/rubicon/rubicon.go:1102:	updateBidExtWithMetaNetworkId		82.4%
total:									(statements)				84.4%

@bsardo
Copy link
Collaborator

bsardo commented Nov 4, 2024

Hi @CTMBNara, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3.
For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

@CTMBNara CTMBNara requested a review from bsardo November 5, 2024 12:43
Copy link

github-actions bot commented Nov 5, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, c1a559d

rubicon

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:176:	appendTrackerToUrl			87.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:192:	Builder					100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:204:	updateRequestTo26			92.3%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:229:	MakeRequests				80.6%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:541:	createImpsToExtMap			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:560:	prepareImpsToExtMap			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:579:	splitMultiFormatImp			61.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:616:	resolveBidFloor				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:624:	updateImpRpTarget			81.8%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:729:	extractDfpAdUnitCode			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:739:	isNotKeyPathError			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:743:	addStringAttribute			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:747:	addStringArrayAttribute			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:751:	updateUserRpTargetWithFpdAttributes	70.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:781:	updateExtWithIabAttribute		100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:790:	populateFirstPartyDataAttributes	92.9%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:818:	isStringArray				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:828:	isBoolArray				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:838:	convertToStringArray			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:849:	rawJSONToMap				100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:857:	mapFromRawJSON				80.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:866:	getSegmentIdsToCopy			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:886:	contains				75.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:895:	isVideo					100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:904:	isFullyPopulatedVideo			100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:909:	resolveNativeObject			88.2%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:941:	setImpNative				82.4%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:970:	MakeBids				92.2%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1070:	mapImpIdToCpmOverride			90.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1088:	resolveAdm				87.5%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1103:	cmpOverrideFromBidRequest		100.0%
github.com/prebid/prebid-server/v3/adapters/rubicon/rubicon.go:1112:	updateBidExtWithMetaNetworkId		82.4%
total:									(statements)				84.5%

@bsardo
Copy link
Collaborator

bsardo commented Nov 12, 2024

@MaksymTeqBlaze can you please review?

@bsardo bsardo merged commit b2023fd into master Dec 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants