Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Adapter: FeedAd #4104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

New Adapter: FeedAd #4104

wants to merge 2 commits into from

Conversation

andwun
Copy link

@andwun andwun commented Dec 13, 2024 •
edited
Loading

This PR adds the FeedAd PBS adapter
Docs PR: prebid/prebid.github.io#5776

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 67f84c8

feedad

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/feedad/feedad.go:17:	getHeaders	90.9%
github.com/prebid/prebid-server/v3/adapters/feedad/feedad.go:41:	MakeBids	66.7%
github.com/prebid/prebid-server/v3/adapters/feedad/feedad.go:84:	MakeRequests	80.0%
github.com/prebid/prebid-server/v3/adapters/feedad/feedad.go:100:	Builder		100.0%
total:									(statements)	77.8%

@andwun andwun mentioned this pull request Dec 13, 2024
Open
8 tasks
@bsardo bsardo changed the title FeedAd: Initial version of PBS adapter New Adapter: FeedAd Dec 13, 2024
SyntaxNode
SyntaxNode reviewed Dec 13, 2024
View reviewed changes
adapters/feedad/feedad.go
headers.Add("Accept", "application/json")
headers.Add("Content-Type", "application/json;charset=utf-8")
headers.Add("X-FA-PBS-Adapter-Version", feedAdAdapterVersion)
headers.Add("X-Openrtb-Version", "2.5")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to support OpenRTB 2.6 instead?

adapters/feedad/feedadtest/exemplary/banner-web.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Please rename this to banner-site.json to make the test case clear.

adapters/feedad/params_test.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use our standard format documented here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyntaxNode SyntaxNode SyntaxNode left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andwun @SyntaxNode