Rubicon: Remove pchain support #4166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
rubiconRefer here for heat map coverage report |
bsardo
changed the title
bsardo
reviewed
Feb 11, 2025
Code coverage summaryNote:
rubiconRefer here for heat map coverage report |
guscarreon
reviewed
Feb 13, 2025
Code coverage summaryNote:
rubiconRefer here for heat map coverage report |
bsardo
approved these changes
Feb 18, 2025
guscarreon
reviewed
Feb 18, 2025
|
|
||
| sourceCopyExt.SChain = sourceCopy.SChain | ||
| sourceCopy.SChain = nil | ||
| if request.Source != nil && request.Source.SChain != nil { |
There was a problem hiding this comment.
Consider the following test case:
{
desc: "3) non-nil source, pchain = \"\", nil SChain",
in: testInput{
request: &openrtb2.BidRequest{
Source: &openrtb2.Source{TID: "someSourceTID"},
},
pChain: "",
},
},
The && operator will prevent the request.Source to get copied to rubiconRequest.Source causing a loss of information that request.Source might be carrying, like the request.Source.TID field set to "someSourceTID" in our example. Is this the desired behavior?
If not, 4 of the 6 scenarios considered below, fail because of this logic.
func TestFunc(t *testing.T) {
type testInput struct {
request *openrtb2.BidRequest
pChain string
}
testCases := []struct {
desc string
in testInput
}{
{
desc: "1) nil Source, pchain = \"\"",
in: testInput{
request: &openrtb2.BidRequest{},
pChain: "",
},
},
{
desc: "2) nil Source, pchain = \"pchain\"",
in: testInput{
request: &openrtb2.BidRequest{},
pChain: "pchain",
},
},
{
desc: "3) non-nil source, pchain = \"\", nil SChain",
in: testInput{
request: &openrtb2.BidRequest{
Source: &openrtb2.Source{TID: "someSourceTID"},
},
pChain: "",
},
},
{
desc: "4) non-nil Source, pchain = \"\", non-nil SChain",
in: testInput{
request: &openrtb2.BidRequest{
Source: &openrtb2.Source{
TID: "someSourceTID",
SChain: &openrtb2.SupplyChain{
Complete: 0,
},
},
},
pChain: "",
},
},
{
desc: "5) non-nil Source, pchain = \"pchain\", nil SChain",
in: testInput{
request: &openrtb2.BidRequest{
Source: &openrtb2.Source{TID: "someSourceTID"},
},
pChain: "pchain",
},
},
{
desc: "6) non-nil Source, pchain = \"pchain\", non-nil SChain",
in: testInput{
request: &openrtb2.BidRequest{
Source: &openrtb2.Source{
TID: "someSourceTID",
SChain: &openrtb2.SupplyChain{
Complete: 0,
},
},
},
pChain: "pchain",
},
},
}
for _, tc := range testCases {
beforeResult := &openrtb2.BidRequest{}
afterResult := &openrtb2.BidRequest{}
before(tc.in.request, beforeResult, tc.in.pChain)
after(tc.in.request, afterResult, tc.in.pChain)
assert.Equal(t, beforeResult, afterResult, tc.desc)
}
}
There was a problem hiding this comment.
The only reason to change the source is having a schain field, otherwise we don't even need to make a copy of the source
I don't see any information loss since the rubiconRequest is a copy of request and the source is kept unchanged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.