Fixing bug related to http fetcher accumulating query params from multiple calls #4648
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Prevent duplicate account IDs in query parameters when fetching accounts
Problem
When
FetchAccountsis called multiple times, the same account ID appears multiple times in the query string. For example, instead of?account-id=280, the query becomes?account-id=280&account-id=280.Root Cause
In the
FetchAccountsmethod, the code creates a reference tofetcher.EndpointURLrather than a copy:Fixing that by creating a deep copy.
Testing
Tested by locally running prebid-server and hitting cookie_sync endpoint multiple times in succession to find endpoint being hit correctly.