-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDPR support for legacy adapters #497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice and simple.
@bretg take note of this one... this affects the legacy API for GDPR. As discussed we'll let it sit for a week or so (unless you come by and say you're cool if we merge it sooner). |
Great! Thanks. |
@pycnvr Beware the nuances discussed in #501 The legacy I can still merge this because I don't think it hurts anything, but there might need to be more work here before we can really call this endpoint "GDPR-safe". |
* OTT-1084: Adding vast version count prometheus stats
Please review the following change that passes along the two GDPR parameters for legacy adapters. Essentially the adapters do not need to change as long as the openrtb request generated by MakeOpenRTBGeneric is used directly.