Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR support for legacy adapters #497

Merged
merged 1 commit into from
May 15, 2018

Conversation

pycnvr
Copy link
Contributor

@pycnvr pycnvr commented May 8, 2018

Please review the following change that passes along the two GDPR parameters for legacy adapters. Essentially the adapters do not need to change as long as the openrtb request generated by MakeOpenRTBGeneric is used directly.

  • Add Regs to PBSRequest
  • Pass along Regs in legacy conversion
  • In MakeOpenRTBGeneric, picks up User.Ext if available, and also picks up Regs.

Copy link
Contributor

@cirla cirla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and simple.

@dbemiller dbemiller added the External API impact Tag for issues and PRs which affect the external API label May 9, 2018
@dbemiller
Copy link
Contributor

dbemiller commented May 9, 2018

@bretg take note of this one... this affects the legacy API for GDPR. As discussed we'll let it sit for a week or so (unless you come by and say you're cool if we merge it sooner).

@pycnvr
Copy link
Contributor Author

pycnvr commented May 9, 2018

Great! Thanks.

@dbemiller
Copy link
Contributor

@pycnvr Beware the nuances discussed in #501

The legacy /auction endpoint returns cookie sync URLs as well, so it still may not be GDPR-safe, depending on what the Client is doing.

I can still merge this because I don't think it hurts anything, but there might need to be more work here before we can really call this endpoint "GDPR-safe".

@dbemiller dbemiller merged commit 2ae0666 into prebid:master May 15, 2018
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 1, 2020
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 2, 2020
katsuo5 pushed a commit to flux-dev-team/prebid-server-1 that referenced this pull request Dec 4, 2020
pm-nilesh-chate pushed a commit to pm-nilesh-chate/prebid-server that referenced this pull request Jun 21, 2023
* OTT-1084: Adding vast version count prometheus stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External API impact Tag for issues and PRs which affect the external API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants